Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorials and add tutorial testenv #1039

Merged
merged 10 commits into from
May 19, 2022
Merged

Conversation

eleftherioszisis
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v4@006cafc). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             v4     #1039   +/-   ##
======================================
  Coverage      ?   100.00%           
======================================
  Files         ?        35           
  Lines         ?      2464           
  Branches      ?         0           
======================================
  Hits          ?      2464           
  Misses        ?         0           
  Partials      ?         0           

@eleftherioszisis eleftherioszisis changed the title Fix tutorials and add check-tutorial testenv Fix tutorials and add tutorial testenv May 19, 2022
Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure I understand what happens: it just executes all the cells of the notebook to check they all succeed but it does not check anything on the results, right?

@eleftherioszisis
Copy link
Contributor Author

Just to be sure I understand what happens: it just executes all the cells of the notebook to check they all succeed but it does not check anything on the results, right?

Yep, exactly. Just runs them.

@adrien-berchet
Copy link
Member

Yep, exactly. Just runs them.

Ok, thanks!

@eleftherioszisis eleftherioszisis merged commit d68d656 into v4 May 19, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/test-tutorial branch May 19, 2022 14:41
eleftherioszisis pushed a commit that referenced this pull request May 14, 2024
* Mixed subtree processing (#981)
* Refactor tests for test_mixed.py (#1027)
* Remove deprecated modules and functions/classes & warnings (#1026, #1032)
* Use readonly morphio Morphology by default (#979)
* Morphology level radial distance features use the soma as reference point (#1030)
* Expose subtree processing from the morph_stats api (#1034)
* Remove pyXX prefix for lint, docs, and coverage (#1038)
* Fix tutorials and add tutorial testenv (#1039)
* Add isort for formatting/linting (#1040)
* Add testing of example scripts (#1041)
* Make documentation/docstrings testable (#1035)
* Add black to neurom, format everything, and add to lint (#1042)
* Fix load_morpholgies to always resolve paths (#1047)
* allow Morphology objects to be either mut or immut (#1049)
* Replace iter_* methods by properties in core objects and improve iter_segments (#1054)
* Decouple Morphology constructor from io (#1120)
* Move soma methods to functions (#1118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants