-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add tray icon with (up to) 10 last updated notes #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Cool! |
|
I don't know why the test is suddenly failing. Here's a deprecation warning:
|
|
@Redsandro Please ignore the test. It fails randomly. I'll fix it later. |
|
Fixed merge conflict. |
|
@Redsandro Which OSs did you test? |
|
@Rokt33r Linux/Cinnamon. The tray icon stays. Hadn't given much thought to other Operating Systems handling it differently to be honest. I don't have OSX or Windows. 🤔 Do you have ideas? I have given you permission to do commits on top of this PR. |
|
Don't worry! I have one with macOS. I'll fix it today. 😄 |
|
Great! 😄 |
|
@Rokt33r any update on this? |
|
@Redsandro Sorry, I've forgotten to review this... I'll do it in this weekend. 🙏 🙏 |
|
Heya, any updates on this or an overlook if it will be addressed soon? Thanks! |
|
+1 This would be nice to have |
# Conflicts: # browser/main/Main.js # browser/main/NoteList/index.js # browser/main/modals/PreferencesModal/UiTab.js # lib/main-window.js
Tray Menu
|
@AWolf81 just brought this back to mainline. 👍 |
|
You're welcome. During testing your branch I have noticed the following points that we should check:
|
|
@AWolf81 I must admit that I have lost interest in this PR due to lack of interest from the maintainers. If you are motivated to see this through, I can add you as a collaborator to my fork, or you can fork my branch and create a new PR. |
|
@Redsandro thanks for your info and no problem. I understand that it's not motivating to have a PR that long open with-out finishing it in a timely manner but I think the maintainers are busy with other stuff and I think it's OK that it takes some time to get things ready - a year is sure not acceptable but it can happen to forget to address PRs... And there are more important features that have a higher priority than the tray icon feature - maybe a road map with an overview of the features and improvements would be great to have. That would also help to be more focused on the important parts. Not sure if there is anything like a Trello board or Github projects or Zenhub to track these things but it would be great to have. I've used Zenhub before and it integrates nicely in Github with a browser extension but re-activating a GH project for tracking issues would be also OK. It is also a lot of work to get over 70 PRs merged with just some maintainers. Not sure how many people are actively working on it but I think there are around three collaborators with write access that are active at the moment. Anyway, thanks for your efforts and I'll try to finalize your work and check if I can improve the mentioned points. I'll create a new PR to add the improvements. I hope I stay motivated because I really like working on Boostnote and I like the app. But the speed of getting PRs merged could be better... |



Here is a feature I'm missing from Tomboy Notes, showing the last edited items in the system tray.
A hook is placed in the same location as #1528 so there will be a merge conflict; please consider that PR first.