Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tray icon with (up to) 10 last updated notes #1536

Open
wants to merge 8 commits into
base: master
from

Conversation

@Redsandro
Copy link
Contributor

Redsandro commented Feb 11, 2018

Here is a feature I'm missing from Tomboy Notes, showing the last edited items in the system tray.

image

A hook is placed in the same location as #1528 so there will be a merge conflict; please consider that PR first.

Redsandro added 2 commits Feb 11, 2018
@kazup01

This comment has been minimized.

Copy link
Member

kazup01 commented Feb 12, 2018

Cool!

@kazup01 kazup01 requested a review from Rokt33r Feb 12, 2018
@Redsandro

This comment has been minimized.

Copy link
Contributor Author

Redsandro commented Feb 15, 2018

@kazup01 @Rokt33r Some people might prefer not to keep Boostnote (the tray icon with latest notes) open, so I've added the option to uncheck this behavior.

image

Unchecking this will quit the app when the main window is closed, same to the behavior prior to this PR.

@Redsandro

This comment has been minimized.

Copy link
Contributor Author

Redsandro commented Feb 16, 2018

I don't know why the test is suddenly failing.

Here's a deprecation warning:

value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.

@Rokt33r

This comment has been minimized.

Copy link
Member

Rokt33r commented Feb 17, 2018

@Redsandro Please ignore the test. It fails randomly. I'll fix it later.

@Redsandro

This comment has been minimized.

Copy link
Contributor Author

Redsandro commented Feb 20, 2018

Fixed merge conflict.

@Rokt33r

This comment has been minimized.

Copy link
Member

Rokt33r commented Feb 22, 2018

@Redsandro Which OSs did you test?

@Rokt33r

This comment has been minimized.

Copy link
Member

Rokt33r commented Feb 22, 2018

The tray icon is not visible on macOS.

Idle :
screen shot 2018-02-22 at 11 55 36 am
Focused :
screen shot 2018-02-22 at 11 55 42 am

@Redsandro

This comment has been minimized.

Copy link
Contributor Author

Redsandro commented Feb 22, 2018

@Rokt33r Linux/Cinnamon. The tray icon stays. Hadn't given much thought to other Operating Systems handling it differently to be honest. I don't have OSX or Windows. 🤔 Do you have ideas? I have given you permission to do commits on top of this PR.

@Rokt33r

This comment has been minimized.

Copy link
Member

Rokt33r commented Feb 22, 2018

Don't worry! I have one with macOS. I'll fix it today. 😄

@Redsandro

This comment has been minimized.

Copy link
Contributor Author

Redsandro commented Feb 22, 2018

Great! 😄

@Redsandro

This comment has been minimized.

Copy link
Contributor Author

Redsandro commented May 26, 2018

@Rokt33r any update on this?

@Rokt33r

This comment has been minimized.

Copy link
Member

Rokt33r commented Jun 1, 2018

@Redsandro Sorry, I've forgotten to review this... I'll do it in this weekend. 🙏 🙏

@jcB0085

This comment has been minimized.

Copy link

jcB0085 commented Jul 22, 2018

Heya, any updates on this or an overlook if it will be addressed soon? Thanks!

@rmatelec

This comment has been minimized.

Copy link

rmatelec commented Jan 31, 2019

+1 This would be nice to have

AWolf81 added 2 commits Jul 1, 2019
# Conflicts:
#	browser/main/Main.js
#	browser/main/NoteList/index.js
#	browser/main/modals/PreferencesModal/UiTab.js
#	lib/main-window.js
@AWolf81 AWolf81 mentioned this pull request Jul 1, 2019
Tray Menu
@Redsandro

This comment has been minimized.

Copy link
Contributor Author

Redsandro commented Jul 2, 2019

@AWolf81 just brought this back to mainline. 👍

@AWolf81

This comment has been minimized.

Copy link
Contributor

AWolf81 commented Jul 2, 2019

You're welcome.

During testing your branch I have noticed the following points that we should check:

  • After starting it seems like the tray menu is not loading the most recently edited notes. I think after clicking on a storageLocation it will correctly show the menu.
  • The tray is showing the recently edited notes related to currently selected storage location. Is this like we want it? IMO it would be better to have the recently edited notes across all storage locations - like it is with the note links below the search field.
  • I had sometimes multiple tray icon symbols - not sure if this is related to hot module reloading or if there is a real problem.
@Redsandro

This comment has been minimized.

Copy link
Contributor Author

Redsandro commented Jul 3, 2019

@AWolf81 I must admit that I have lost interest in this PR due to lack of interest from the maintainers.

If you are motivated to see this through, I can add you as a collaborator to my fork, or you can fork my branch and create a new PR.

@AWolf81

This comment has been minimized.

Copy link
Contributor

AWolf81 commented Jul 3, 2019

@Redsandro thanks for your info and no problem.

I understand that it's not motivating to have a PR that long open with-out finishing it in a timely manner but I think the maintainers are busy with other stuff and I think it's OK that it takes some time to get things ready - a year is sure not acceptable but it can happen to forget to address PRs...

And there are more important features that have a higher priority than the tray icon feature - maybe a road map with an overview of the features and improvements would be great to have. That would also help to be more focused on the important parts. Not sure if there is anything like a Trello board or Github projects or Zenhub to track these things but it would be great to have.

I've used Zenhub before and it integrates nicely in Github with a browser extension but re-activating a GH project for tracking issues would be also OK.

It is also a lot of work to get over 70 PRs merged with just some maintainers. Not sure how many people are actively working on it but I think there are around three collaborators with write access that are active at the moment.

Anyway, thanks for your efforts and I'll try to finalize your work and check if I can improve the mentioned points. I'll create a new PR to add the improvements.

I hope I stay motivated because I really like working on Boostnote and I like the app. But the speed of getting PRs merged could be better...

@Redsandro

This comment has been minimized.

Copy link
Contributor Author

Redsandro commented Jul 3, 2019

@AWolf81 about half a dozen of my PR's were merged reasonably quickly. This one is a clear outlier. Not sure if team is just not interested or if there are bigger problems related to this PR. Perhaps @Rokt33r can shed some light before you do too much effort.

@AWolf81 AWolf81 mentioned this pull request Jul 3, 2019
5 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.