OnBlur throws exceptions if the notetype is snippet -> Fixes #1962 #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
requested changes
May 28, 2018
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
Please confirm my review!
| if (attachmentsInNote) { | ||
| for (let i = 0; i < attachmentsInNote.length; i++) { | ||
| attachmentsInNoteOnlyFileNames.push(attachmentsInNote[i].replace(new RegExp(STORAGE_FOLDER_PLACEHOLDER + escapeStringRegexp(path.sep) + noteKey + escapeStringRegexp(path.sep), 'g'), '')) | ||
| if (storageKey && noteKey && markdownContent !== null && typeof markdownContent !== 'undefined') { |
Member
There was a problem hiding this comment.
please write like below:
if (storageKey != null && noteKey != null && markdownContent != null)
Contributor
Author
There was a problem hiding this comment.
you are right and i've fixed the issue like you suggested
kazup01
added
awaiting changes 🖊️
Contributor
Author
|
@sosukesuzuki i've changed it like you said ;) |
kazup01
added
awaiting review ❇️
sosukesuzuki
reviewed
Jun 4, 2018
| if (attachmentsInNote) { | ||
| for (let i = 0; i < attachmentsInNote.length; i++) { | ||
| attachmentsInNoteOnlyFileNames.push(attachmentsInNote[i].replace(new RegExp(STORAGE_FOLDER_PLACEHOLDER + escapeStringRegexp(path.sep) + noteKey + escapeStringRegexp(path.sep), 'g'), '')) | ||
| if (storageKey != null && noteKey != null && markdownContent != null) { |
Member
There was a problem hiding this comment.
It might be better for this to be able to reduce nesting, like below:
if (storageKey == null || noteKey == null || markdownContent == null) return
kazup01
added
awaiting changes 🖊️
sosukesuzuki
reviewed
Jun 6, 2018
| for (let i = 0; i < attachmentsInNote.length; i++) { | ||
| attachmentsInNoteOnlyFileNames.push(attachmentsInNote[i].replace(new RegExp(STORAGE_FOLDER_PLACEHOLDER + escapeStringRegexp(path.sep) + noteKey + escapeStringRegexp(path.sep), 'g'), '')) | ||
| } | ||
| if (storageKey == null || noteKey == null || markdownContent == null) { |
Member
There was a problem hiding this comment.
{} is unnecessary.please write like below:
if (storageKey == null || noteKey == null || markdownContent == null) return
Rokt33r
added
next release (v0.11.6)
and removed
awaiting changes 🖊️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only inserted an additional IF..