Fix search value for html export path #2171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rokt33r
added
awaiting changes 🖊️
Rokt33r
requested changes
Jul 17, 2018
|
|
||
| files.forEach((file) => { | ||
| file = file.replace('file://', '') | ||
| file = file.replace('file:///', '') |
Member
There was a problem hiding this comment.
This fix doesn't work on macOS. I think we have to check which os is used.
if (global.process.platform === 'win32') {
file = file.replace('file:///', '')
} else {
file = file.replace('file://', '')
}
Contributor
Author
There was a problem hiding this comment.
Thanks for your review. I fixed it.
This was referenced Jul 31, 2018
kazup01
added
awaiting review ❇️
Rokt33r
added
next release (v0.11.9)
and removed
awaiting review ❇️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue: #2159
The path generated by
file-urlbegins withfile:///.