Fix for issue #2088 : snippet notes are not displaying in markdown #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2018 22:23
Fix for issue BoostIO#2088. In specific situation, when all below conditions are met : - one of the snippets notes tabs is a Markdown tab, - the migrateAttachments code is called on a snippet note, - historical attachments location '/images' exists in snippet storage folder Following exception is being thrown : path.js:28 Uncaught TypeError: Path must be a string. Received undefined The exception is a result of an undefined noteKey variable (which is defined only for Markdown notes). The solution is to skip migration of attachments for notes without noteKey (which wouldn't be possible anyway, since noteKey is a necessary for creating folder for attachments).
The original condition : attachments !== [] always returns true, for empty array, as well as for array with elements.
Rokt33r
added
next release (v0.11.9)
and removed
awaiting review ❇️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2088.
In specific situation, when all below conditions are met :
Following exception is being thrown :
As a result, Markdown tab is not being rendered.
The exception is a result of an undefined noteKey variable (which is defined only for full Markdown notes, not for Markdown tabs of a Snippet Note).
The solution is to skip migration of attachments for notes without noteKey (which wouldn't be possible anyway, since noteKey is a necessary for creating folder for attachments).
Additionally, the condition
attachments !== []has been changed toattachments.length, because the first one always returns true , as in simple js console example :