Skip to content

Conversation

@GuilhermeJSilva
Copy link
Contributor

@GuilhermeJSilva GuilhermeJSilva commented Nov 8, 2018

Description

Added 3 text fields so the user can pick which characters are matched. Ex: When a ( is insert a ) is added.

Issue fixed

#2508

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 9, 2018
@GuilhermeJSilva
Copy link
Contributor Author

The issue description was updated to comply with the standard

@FilipaDurao
Copy link

@ZeroX-DG, @Rokt33r, @ehhc
Good morning,
this issue was solved as an assignement on a curricular unit at our college (link here: https://sigarra.up.pt/feup/en/UCURR_GERAL.FICHA_UC_VIEW?pv_ocorrencia_id=420001)
It would be a very big help for me and my colleagues if this issue was accepted, for it would raise our grade. Of course we are not asking you to accept it if it is below the standards or not what you need, but if it is and you could give us your feedback until the beggining of January our grade would improve.
Thank you very much!

@Rokt33r
Copy link
Member

Rokt33r commented Dec 20, 2018

@FilipaDurao I'll review it on this weekends.

@FilipaDurao
Copy link

Thank you so much @Rokt33r !

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you for your contribution. I also need a review from @Rokt33r before we merge this.

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 21, 2018
@ZeroX-DG ZeroX-DG requested a review from Rokt33r December 21, 2018 03:46
@FilipaDurao
Copy link

Thank you very much @ZeroX-DG !

@Rokt33r Rokt33r added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Dec 22, 2018
@Rokt33r Rokt33r added approved 👍 Pull request has been approved by sufficient reviewers. next release (v0.11.13) and removed awaiting review ❇️ Pull request is awaiting a review. approved 👍 Pull request has been approved by sufficient reviewers. labels Dec 23, 2018
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://travis-ci.org/BoostIO/Boostnote/builds/467470171
@GuilhermeJSilva Could you fix this? I'll merge this pr as soon as you fix.

@GuilhermeJSilva
Copy link
Contributor Author

@Rokt33r Errors fixed

@Rokt33r Rokt33r merged commit 604f17f into BoostIO:master Dec 24, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Dec 25, 2018

@GuilhermeJSilva Could you submit the url of this pr to issuehunt? Seems there are bounties on the issue.
https://issuehunt.io/repos/53266139/issues/2218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants