Skip to content

Conversation

@jaconey
Copy link

@jaconey jaconey commented Dec 9, 2018

issue: #2218
screen shot 2018-12-09 at 10 10 45 pm

Description

  1. Add new configuration to enable/disable auto close on '*' and '$'
  2. Update CodeEditor to read from the new configuration

Issue fixed

#2218

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@jaconey
Copy link
Author

jaconey commented Dec 10, 2018

@Rokt33r Hey, can you please take a look when you have a chance? Thanks!

@jaconey
Copy link
Author

jaconey commented Dec 22, 2018

I merged in the latest changes from Boostnode:master and the PR looks diverged... Please only pull ea37543 and 645d30c. Sorry for the confusion.

@Rokt33r
Copy link
Member

Rokt33r commented Dec 23, 2018

#2586 will cover this feature!

@Rokt33r Rokt33r closed this Dec 23, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Dec 23, 2018

Sorry for closing the pr 😢 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants