Skip to content

Conversation

@richardtks
Copy link
Contributor

Description

When the note contains quad quotes: '''', it will casuing the parsing error when loading the note.

Issue fixed

#300

Type of changes

  • πŸ”˜ Bug fix (Change that fixed an issue)
  • βšͺ Breaking change (Change that can cause existing functionality to change)
  • βšͺ Improvement (Change that improves the code. Maybe performance or development improvement)
  • βšͺ Feature (Change that adds new functionality)
  • βšͺ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ My code follows the project code style
  • βšͺ I have written test for my code and it has been tested
  • πŸ”˜ All existing tests have been passed
  • πŸ”˜ I have attached a screenshot/video to visualize my change if possible

NOTE:

Please note that cson-parser v4.0 do not support yarn engine, if you want to use yarn engine to install the dependency, please use yarn --ignore-engines

Screenshot:

result 300

@Rokt33r Rokt33r self-requested a review December 25, 2018 08:58
@Rokt33r
Copy link
Member

Rokt33r commented Dec 25, 2018

This won't be merged. If it works fine, I'll update my forked dependencies for security reasons.

@Rokt33r Rokt33r added the needs investigation πŸ”¬ Issue requires further investigation to locate or narrow down the problem. label Dec 25, 2018
@richardtks
Copy link
Contributor Author

richardtks commented Dec 25, 2018

This won't be merged. If it works fine, I'll update my forked dependencies for security reasons.

@Rokt33r, understand. you can test the branch in https://github.com/richardtks/Boostnote/tree/season-upgrade

Please note that latest cson-parser do not suport yarn engine...

cson-parser: https://github.com/richardtks/cson-parser/tree/fix-quod-quote-4.0
season: https://github.com/richardtks/season/tree/upgrade-cson-parser-v4.0.1

@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Dec 25, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jun 2, 2020

I think the bug has been fixed somehow along the way. I'll close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review. needs investigation πŸ”¬ Issue requires further investigation to locate or narrow down the problem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants