Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert Date ISO 8601 Style #3064 #3363

Closed
wants to merge 1 commit into from

Conversation

@ceqi
Copy link

ceqi commented Nov 16, 2019

Description

Insert the date and dateTime with ISO8601 format using hotkeys.
This PR will close

Issue fixed

#3064

  • Insert ISO8601 date with hotkeys
  • Insert ISO8601 dateTime with hotkeys

Type of changes

  • ⚪️ Bug fix (Change that fixed an issue)
  • ⚫️ Breaking change (Change that can cause existing functionality to change)
  • ⚪️ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪️ Feature (Change that adds new functionality)
  • ⚪️ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚫️ My code follows the project code style

  • ⚪️ I have written test for my code and it has been tested

  • ⚫️ All existing tests have been passed

  • ⚫️ I have attached a screenshot/video to visualize my change if possible

    iso8601date dateTime


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

ce.qi
@ZeroX-DG

This comment has been minimized.

Copy link
Member

ZeroX-DG commented Nov 28, 2019

Are there any advantage for changing this to ISO format? Can you explain it to me please?

@ceqi

This comment has been minimized.

Copy link
Author

ceqi commented Nov 28, 2019

Hi @ZeroX-DG,

This PR is for #3064, issue is opened by @gerryw1389, who’s in better position to explain the motivation of the change.

One of the advantages I could think of is that the ISO format eliminates the date ambiguity.

For example:
01/02/2019 could mean 1st of Feb or 2nd of Jan as the format could be either MM/DD/YYYY or DD/MM/YYYY

While using ISO 8601, the format is YYYY-MM-DD

@Flexo013

This comment has been minimized.

Copy link

Flexo013 commented Nov 28, 2019

@ceqi Would this overwrite the current behavior of the hotkeys? If so, can you make it configurable?
Also what hotkeys are you using? (Just to make sure we keep the docs up to date)

@ceqi

This comment has been minimized.

Copy link
Author

ceqi commented Nov 28, 2019

@Flexo013

  1. Yes. this change will overwrite current date format.

  2. Making inserted date format configurable may need some discussions beforehand:

    • the necessity of making date format configurable;
    • where to add the configuration option (when needed)

    Perhaps it deserves it's own ticket?

  3. Hotkeys used are shown below:

Screenshot 2019-11-28 at 21 42 56

@ZeroX-DG

This comment has been minimized.

Copy link
Member

ZeroX-DG commented Nov 28, 2019

I think we gonna accept this PR instead: #3094
That PR allows us to customise the date format instead of overriding it. I don't really use ISO format and I think customising date format is a necessity.

I'm sorry to close this PR but thank you very much for the effort. You are always welcome to contribute on Boostnote on other features.

@ZeroX-DG ZeroX-DG closed this Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.