-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Changing Notes CSON to Markdown #3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will also put @arcturus140's question here:
Additionally could add this checklist to your PR description? |
|
Since this format is incompatible with the existing one it requires to increase the major of |
|
Well it's better to have a tool for converting cson to markdown (separated from the main app). The main app will only parse any markdown file and show a small list of cson file not being parsed and saying users need to use a tool to convert them. What do you guys think? |
|
@ZeroX-DG we don't even need to list files, jsonData.version already tells which format we have per storage. Then show a pop up to force an upgrade of the entire storage location. if external tool or internal is only a matter of convenience. |
|
the thing is, once upgraded there's no turning back, so we force everyone to update to the latest version - shared devices and team members... I'm sticking with an older version, because of some bugs in the later. I'm sure I'm not the only one, since making updates optional is also a highly wanted feature. but we gotta do it anyway at some point, so... |
|
if boostnote use md as default format, so that I can directly map path to jekyll , make blog easily . |
| const meta = _.omit(input, ['key', 'storage', 'content']) | ||
| const result = CSON.stringify(meta) | ||
|
|
||
| return `<!--\n${result}\n-->${content ? `\n\n${content}` : ''}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using the frontmattre format or at least make it configurable?
|
any plans to merge and release this? |
Changing notes files to use .md instead of .cson. #490
Type of changes
[ ] Bug fix (Change that fixed an issue)
[x] Breaking change (Change that can cause existing functionality to change)
[ ] Improvement (Change that improves the code. Maybe performance or development improvement)
[ ] Feature (Change that adds new functionality)
[ ] Documentation change (Change that modifies documentation. Maybe typo fixes)
Checklist:
[x] My code follows the project code style
[x] I have written test for my code and it has been tested
[x] All existing tests have been passed
[ ] I have attached a screenshot/video to visualize my change if possible
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor