Skip to content

Conversation

@sudomf
Copy link
Contributor

@sudomf sudomf commented Jan 23, 2020

Changing notes files to use .md instead of .cson. #490

Type of changes
[ ] Bug fix (Change that fixed an issue)
[x] Breaking change (Change that can cause existing functionality to change)
[ ] Improvement (Change that improves the code. Maybe performance or development improvement)
[ ] Feature (Change that adds new functionality)
[ ] Documentation change (Change that modifies documentation. Maybe typo fixes)
Checklist:
[x] My code follows the project code style
[x] I have written test for my code and it has been tested
[x] All existing tests have been passed
[ ] I have attached a screenshot/video to visualize my change if possible


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jan 24, 2020
@Flexo013
Copy link
Contributor

I will also put @arcturus140's question here:

what happens with existing .cson notes?

Additionally could add this checklist to your PR description?

Type of changes
[ ] Bug fix (Change that fixed an issue)
[ ] Breaking change (Change that can cause existing functionality to change)
[ ] Improvement (Change that improves the code. Maybe performance or development improvement)
[ ] Feature (Change that adds new functionality)
[ ] Documentation change (Change that modifies documentation. Maybe typo fixes)
Checklist:
[ ] My code follows the project code style
[ ] I have written test for my code and it has been tested
[ ] All existing tests have been passed
[ ] I have attached a screenshot/video to visualize my change if possible

@arcturus140
Copy link
Contributor

arcturus140 commented Jan 25, 2020

Since this format is incompatible with the existing one it requires to increase the major of jsonData.version for proper handling.

@ZeroX-DG
Copy link
Member

Well it's better to have a tool for converting cson to markdown (separated from the main app). The main app will only parse any markdown file and show a small list of cson file not being parsed and saying users need to use a tool to convert them. What do you guys think?

@arcturus140
Copy link
Contributor

arcturus140 commented Jan 27, 2020

@ZeroX-DG we don't even need to list files, jsonData.version already tells which format we have per storage. Then show a pop up to force an upgrade of the entire storage location.

if external tool or internal is only a matter of convenience.

@arcturus140
Copy link
Contributor

the thing is, once upgraded there's no turning back, so we force everyone to update to the latest version - shared devices and team members...

I'm sticking with an older version, because of some bugs in the later. I'm sure I'm not the only one, since making updates optional is also a highly wanted feature.

but we gotta do it anyway at some point, so...

@eromoe
Copy link

eromoe commented Mar 22, 2020

if boostnote use md as default format, so that I can directly map path to jekyll , make blog easily .
And this #3117 would be easy too.

@ZeroX-DG ZeroX-DG added the discussion 💬 Issue concerns a discussion. label Apr 12, 2020
const meta = _.omit(input, ['key', 'storage', 'content'])
const result = CSON.stringify(meta)

return `<!--\n${result}\n-->${content ? `\n\n${content}` : ''}`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using the frontmattre format or at least make it configurable?

@c33s
Copy link

c33s commented Mar 6, 2021

any plans to merge and release this?

@sudomf sudomf closed this Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review. discussion 💬 Issue concerns a discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants