Skip to content

Conversation

@rathod-sahaab
Copy link

@rathod-sahaab rathod-sahaab commented Sep 8, 2020

Description

This PR provides feature requested in #2960 by adding a dialog that enables to perform operations on multiple selected notes like:

  • (Un)Pining
  • (Un)Staring
  • Exporting
  • Deleting
  • Publishing
  • Adding/Removing Tags
  • The dialog automatically pops up when multiple notes are selected

image

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ✔️ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have637 written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ✔️ I have attached a screenshot/video to visualize my change if possible
  • ✔️ This PR will modify the UI or affects the UX
  • ⚪ This PR will add/update/delete a keybinding

TODO

  • Toggle only when multiple selected

  • Add tool-tips

  • add missing icons

  • Link UI to functionality

  • Add tags feature


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Sep 13, 2020
@rathod-sahaab
Copy link
Author

multiple-selection-dialog
Upper row(star, pin, unstar, unpin) functional 😄

@rathod-sahaab
Copy link
Author

Taking a break from this will continue in October 😄

@rathod-sahaab rathod-sahaab force-pushed the multiple-selection-dialog branch from 22ec3f7 to e1009d4 Compare December 27, 2020 12:00
@rathod-sahaab rathod-sahaab marked this pull request as ready for review December 27, 2020 12:46
@rathod-sahaab rathod-sahaab changed the title WIP: #2960 - Feature - Add a dialog to perform operations on multiple selected notes #2960 - Feature - Add a dialog to perform operations on multiple selected notes Dec 27, 2020
@rathod-sahaab
Copy link
Author

@Flexo013 up for review

preview #NPI
2020-12-27_21:56:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants