Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html to md feature #3099

Open
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@AWolf81
Copy link
Contributor

commented Jun 29, 2019

Description

I'm addressing the requested review from PR #1980. If I've missed anything please let me know. @StormBurpee I've based this on your branch and addressed the review comments - hope that's OK.

I think the feature is working as expected. The only thing that I have noticed is that the image is not copied to the created note.

What do you think can we address that after this PR or should I put some work into it and check it? But I think we would have to discuss this a bit e.g. copy the image as an asset or create a link to the original location. I think copying would be better.

To the test:
Is the test OK? It just checks that the created note is written to disc and that the keys are correct. I think that's OK as we don't have to check that Turndown is converting the html to markdown correctly.
Or is there anything else to test?

Issue fixed

#923

Type of changes

  • ⚪️ Bug fix (Change that fixed an issue)
  • ⚪️ Breaking change (Change that can cause existing functionality to change)
  • ⚪️ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪️ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪️ I have attached a screenshot/video to visualize my change if possible

Screenshots

Link below the other new note options
grafik

Import dialog with error text
grafik


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

StormBurpee and others added some commits May 26, 2018

Merge branch 'master' into html-to-md
# Conflicts:
#	browser/main/modals/NewNoteModal.js
#	package-lock.json
#	package.json
#	yarn.lock
@ZeroX-DG
Copy link
Member

left a comment

Can you remove the package-lock.json file please? Thank you 👍

reject({result: false, error: 'Please check your URL is in correct format. (Example, https://www.google.com)'})
}

const request = url.includes('https') ? https : http

This comment has been minimized.

Copy link
@ZeroX-DG

ZeroX-DG Jul 7, 2019

Member

Can you replace this with url.startsWith("https") instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.