Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open notes in new window #3110

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@sbencoding
Copy link

commented Jul 7, 2019

Description

This PR adds the ability to open and edit notes in separate, new windows.
The new windows only implement the Detail component, so there's only one main window.
The full screen button has been removed from the new windows, because I don't think it has purpose in that context. The editor already covers the entire window.
I also had to add a new string to i18n: Open in new window. English and Hungarian versions are correct, but for the rest of the languages I simply added the english text.
Some images of the new feature:
image
image

Issue fixed

#1572 [Feature Request] Multiple notes open in their own dedicated windows.

Type of changes

  • ⚪️ Bug fix (Change that fixed an issue)
  • ⚪️ Breaking change (Change that can cause existing functionality to change)
  • ⚪️ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪️ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪️ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.