-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixed approach: Load jQuery statically, and JsRender/JsViews as a Browserify module #295
Comments
It looks as if this may be a bug in my tmplify code. I'll look into it. Meantime you should be able to include jQuery in the client bundle, and it should work OK. |
ok |
If you want to try a local fix for this issue, you can go into the node_modules/jsrender folder and change the last line of jsrender.js: https://github.com/daslicht/jsviews-includes/blob/master/node_modules/jsrender/jsrender.js#L2068 to
|
Interesting. In fact this bug arose because previously I had the code That works in most scenarios, but browserify calls that line of code from a 'compiled function' which has |
Several new and improved documentation topics: - http://www.jsviews.com/#views JsRender view hierarchy - http://www.jsviews.com/#getindex Iterating over arrays: accessing the array index - http://www.jsviews.com/#contextualparams Contextual parameters - http://www.jsviews.com/#parentdata Accessing parent data - http://www.jsviews.com/#apps Building apps - http://www.jsviews.com/#jsrmodel Data / View Model - http://www.jsviews.com/#compiletmpl Using templates - http://www.jsviews.com/#d.templates Registering templates: $.templates() - http://www.jsviews.com/#helpers Using helpers - http://www.jsviews.com/#helpersapi Registering helpers: $.views.helpers() - http://www.jsviews.com/#converters Using converters - http://www.jsviews.com/#convertersapi Registering converters: $.views.converters() Unit tests - Many new unit tests added, especially for Browserify scenarios Bug fixes - BorisMoore/jsrender#295 Issue with Browserify when loading jQuery statically, and JsRender/JsViews as a Browserify module
Several new and improved documentation topics: - http://www.jsviews.com/#views JsRender view hierarchy - http://www.jsviews.com/#getindex Iterating over arrays: accessing the array index - http://www.jsviews.com/#contextualparams Contextual parameters - http://www.jsviews.com/#parentdata Accessing parent data - http://www.jsviews.com/#apps Building apps - http://www.jsviews.com/#jsrmodel Data / View Model - http://www.jsviews.com/#compiletmpl Using templates - http://www.jsviews.com/#d.templates Registering templates: $.templates() - http://www.jsviews.com/#helpers Using helpers - http://www.jsviews.com/#helpersapi Registering helpers: $.views.helpers() - http://www.jsviews.com/#converters Using converters - http://www.jsviews.com/#convertersapi Registering converters: $.views.converters() Unit tests - Many new unit tests added, especially for Browserify scenarios Bug fixes - #295 Issue with Browserify when loading jQuery statically, and JsRender/JsViews as a Browserify module
This has been fixed with commit 75. (v0.9.75) |
Several new and improved documentation topics: - http://www.jsviews.com/#views JsRender view hierarchy - http://www.jsviews.com/#getindex Iterating over arrays: accessing the array index - http://www.jsviews.com/#contextualparams Contextual parameters - http://www.jsviews.com/#parentdata Accessing parent data - http://www.jsviews.com/#apps Building apps - http://www.jsviews.com/#jsrmodel Data / View Model - http://www.jsviews.com/#compiletmpl Using templates - http://www.jsviews.com/#d.templates Registering templates: $.templates() - http://www.jsviews.com/#helpers Using helpers - http://www.jsviews.com/#helpersapi Registering helpers: $.views.helpers() - http://www.jsviews.com/#converters Using converters - http://www.jsviews.com/#convertersapi Registering converters: $.views.converters() Unit tests - Many new unit tests added, especially for Browserify scenarios Bug fixes - BorisMoore/jsrender#295 Issue with Browserify when loading jQuery statically, and JsRender/JsViews as a Browserify module
Hi ,
I tried to implement this approach as described in the documentation and in the node example.
But I still get that jQuery is missing.
Include jQuery in the layout :
https://github.com/daslicht/jsviews-includes/blob/master/app/layout.html#L16
Include the Browserify Bundle:
https://github.com/daslicht/jsviews-includes/blob/master/app/layout.html#L18
Finally include jsrender:
https://github.com/daslicht/jsviews-includes/blob/master/public/index.js#L14
But I still get :
What do I miss/oversee please?
Related:
http://www.jsviews.com/#node/browserify
The text was updated successfully, but these errors were encountered: