Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_BlitzFirst: call sp_BlitzCache differently during the Agent jobs #2009

Closed
BrentOzar opened this issue Mar 23, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@BrentOzar
Copy link
Member

commented Mar 23, 2019

Is your feature request related to a problem? Please describe.
Want to make it easier to see diagnostic data over time.

Describe the solution you'd like
Right now, sp_BlitzFirst runs in a 15-minute Agent job, it calls sp_BlitzCache with a guess based on the top wait type. (It's trying to minimize the amount of work required, and multiple sort methods get slow, fast.)

Instead, let's run sp_BlitzCache with @SkipAnalysis = 1, @SortOrder = 'all', @MinutesBack = 15. We won't get the plan analysis, but it'll go way faster, and we'll be able to sort plans later based on what we're looking for at the time, like showing recent resource-intensive queries in the Azure Data Studio dashboards.

Are you ready to build the code for the feature?
Yes.

@BrentOzar BrentOzar added this to the 2019-04 Release milestone Mar 23, 2019

@BrentOzar BrentOzar self-assigned this Mar 23, 2019

@BrentOzar

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

Turns out there's a related bug: when sp_BlitzCache is called with @SortOrder = 'all', it won't create the output table. Fixing...

BrentOzar added a commit that referenced this issue Apr 23, 2019

#2009 sp_BlitzFirst call BC differently
Use SkipAnalysis = 1, SortOrder = all when calling sp_BlitzCache. Closes #2009.

BrentOzar added a commit that referenced this issue Apr 23, 2019

#2009 sp_BlitzFirst call BC differently (#2030)
Use SkipAnalysis = 1, SortOrder = all when calling sp_BlitzCache. Closes #2009.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.