Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_BlitzCache showing duplicated missing indexes #2070

Closed
BrentOzar opened this issue Jul 2, 2019 · 0 comments · Fixed by #2093

Comments

@BrentOzar
Copy link
Member

commented Jul 2, 2019

Version of the script
SELECT @Version = '7.5', @VersionDate = '20190427';

What is the current behavior?
Incorrect missing index counts. To repro:

  • Run sp_BlitzCache in one session, show a query with a single missing index warning
  • Run it in another session, and the missing index warning will show 2 missing indexes
  • Run it in a third session, and the missing index warning will show 3 missing indexes

Repro:

https://youtu.be/qjrJr8YWsDY

We fixed a similar bug here, but we also need to filter by session ID: https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/pull/1733/files

@BrentOzar BrentOzar added this to the 2019-07 Release milestone Jul 2, 2019

@BrentOzar BrentOzar self-assigned this Jul 2, 2019

@BrentOzar BrentOzar removed this from the 2019-07 Release milestone Jul 2, 2019

BrentOzar added a commit that referenced this issue Aug 26, 2019
#2070 sp_BlitzCache duplicated index count
Filters index recommendations by spid. Closes #2070.
BrentOzar added a commit that referenced this issue Aug 26, 2019
#2070 sp_BlitzCache duplicated index count (#2093)
Filters index recommendations by spid. Closes #2070.
BrentOzar added a commit that referenced this issue Aug 26, 2019
2019-08 Release (#2094)
* #2005 sp_Blitz version numbers (#2006)

Working on #2005.

* #2005 easier merges for versions

Putting Version, VersionDate variables on a single line. Closes #2005.

* #2010 sp_Blitz paused online index operations (#2011)

Add warning for rows in sys.index_resumable_operations. Closes #2010.

* Fix collation error. (#2014)

* #2015 sp_BlitzCache sorting in Azure SQL DB (#2016)

Instead of checking version numbers, look at sys.all_columns for the grant and spill columns. Closes #2015.

* #2024 sp_BlitzQueryStore s.is_cursor error (#2025)

Changed alias on a temp table to match other nearby aliases. Closes #2024.

* First responder consistency check (#1997)

* sp_Blitz update compile and runs on MSSQL 2014

* Update sp_Blitz.sql

Added @debug handling - bug found for missing mandatory component

* Update sp_Blitz.sql

* Update sp_Blitz.sql


CheckId familly:

226 - FRK consistency

Messages:
2260 - First Responder kit consistency check has been unexpectedly modified (check names)
2261 - First Responder kit consistency check has been unexpectedly modified (dynamic query failure)
2262 - First Responder kit mandatory component called %s is missing
2263 - First Responder kit consistency check has been unexpectedly modified (checks ordering)
2264 - Component %s is not at the minimum version required to run this procedure
2265 - First Responder kit consistency check (Failed dynamic SP call to %s)
2266 - First Responder kit consistency: outdated component (%s)

removed "everything ok message"

* Resolves almost all Brent's comments except CHAR(92) change

removed 2264 - Component %s is not at the minimum version required to run this procedure
changed detailled finding message for previous 2264 message

Checked compilation on SQL Server 2014

* #1994 sp_Blitz version checking (#2028)

Changed wording from "consistency check" to "version check," updated check IDs, removed mandatory scripts. Closes #1994.

* #1944 sp_BlitzIndex ignore databases (#2029)

Adds new IgnoreDatabases parameter, and skips databases with >100 partitions. Closes #1944.

* #2009 sp_BlitzFirst call BC differently (#2030)

Use SkipAnalysis = 1, SortOrder = all when calling sp_BlitzCache. Closes #2009.

* #2026 sp_BlitzCache show multiple plan count (#2031)

Closes #2026.

* #2017 sp_Blitz Evaluation Edition expiration check (#2032)

Closes #2017.

* #2018 sp_BlitzCache arith overflow (#2033)

Changing MONEY on totals to BIGINT. Closes #2018.

* #2019 sp_BlitzCache air_quote_actual plans (#2034)

Closes #2019.

* Add END in the right spot for IF @Help = 1 (#2035)

The END for IF @Help = 1 was in the wrong place, making the procedure a no-op *unless* you also specify @Help = 1.

* #2037 sp_BlitzLock support for AWS RDS (#2038)

Skips update stats with options that RDS doesn't support. Closes #2037.

* 2019_04_release_prep

Bumping version numbers, building installation scripts.

* Moved SQL header build outside of If block (#2040)

* #2042 implicit transaction troubleshooting (#2043)

Clarify warnings in sp_Blitz, sp_BlitzFirst. Closes #2042.

* edit hyperlink (#2056)

* add @OutputType = 'XML' (#2048)

* Update sp_blitzcache to avoid arithmetic overflow errors (#2046)

Updated sp_blitzcache to avoid arithmetic overflow errors - tabel definitions had changed to BIGINT but the actual logic in this section still casted values as money which was breaking the ceiling for this on our setup.  I've pretty much blanket chantged everything except averages to be bigint and have been running for a few days with no failrues since so looks ok and worth someone who knows what they're doing casting an eye over it!

* Update sp_ineachdb.sql (#2061)

Added 2 Variables 
@SQLVersion: This was implemented so that large organizations with SQL Server 2008 and R2 can use this sproc.  Currently without this change SQL Server versions 2008 and 2008R2 will error with the following.  Msg 208, Level 16, State 1, Procedure sp_ineachdb, Line 176
Invalid object name 'sys.dm_hadr_database_replica_states'.

@ServerName:  This was added to account for VMware SnapShots at times @@ServerName will either come up NULL or with old server name.  CONVERT(sysname, SERVERPROPERTY('ServerName')) is a better option and reduces minor nuisances.  

Feel free to blend in the code if you feel this brings value to the project.

* ignore readable secondaries in sp_blitzcache (#2049)

* ignore readable secondaries in sp_blitzcache

this is a fix for issue #2027

* Checking for is_primary_replica column

In sys.dm_hadr_database_replica_states.

* 2019_07 Release

Bumping version numbers and updating install scripts.

* Set DBOwner after restoring database (#2082)

* Default @RestoreDiff = NULL
If @RestoreDiff IS NULL and @BackupPathDiff != null: treat RestoreDiff=1

* Set database owner after restore

* Revert restorediff change from dev branch

* Exclude Readable secondary DBs (#2073)

Temp table added (#ReadableDBs) this table is populated with all read intent database id's which is used to filter out these database when querying against dm_exec_requests or sessions with a cross apply against a plan cache function.

* #2067 Updating directory "/" fixing to work with URLs (#2071)

* Updating directory "/" fixing to work with URLs

Also correcting incorrect logging message for fixing @MoveLogDrive slashes

* Fixing variable typo

Data should be log

* #2076 sp_BlitzIndex columnstore to table (#2085)

When saving columnstore definitions to table, trim them to 4000 characters to avoid an overflow. Closes #2076.

* @2060 sp_BlitzFirst 2TB RAM (#2086)

Casting RAM as a BIGINT instead of INT. Closes #2060.

* #2053 sp_BlitzIndex ignoring databases (#2087)

Strip out CR/LF from @IgnoreDatabases, trim spaces afterwards. Closes #2053.

* #2022 sp_BlitzCache disabling air_quote_actuals (#2088)

This SQL 2019 & Azure SQL DB feature isn't ready yet, so disabling til Microsoft is ready. Closes #2022.

* #2044 sp_Blitz new power mode (#2089)

Adds Windows 10's new Ultimate Performance Power Mode, whatever that is. Closes #2044.

* #2062 sp_BlitzFirst false alarm on index reorgs (#2091)

Filtering for sql_text not like %alter index%'. Closes #2062 with duct tape.

* #2052 sp_BlitzCache prioritization (#2092)

Fixes bug in AirQuoteActual plans, plus if plan cache is 75% new as of today, raise priority 1 warning. Closes #2052.

* #2070 sp_BlitzCache duplicated index count (#2093)

Filters index recommendations by spid. Closes #2070.

* sp_DatabaseRestore case bug

Inconsistent case sensitivity.

* 2019-09 release prep

Bumping version numbers and dates.
BrentOzar added a commit that referenced this issue Aug 26, 2019
Updating multi-install scripts. (#2095)
* #2005 sp_Blitz version numbers (#2006)

Working on #2005.

* #2005 easier merges for versions

Putting Version, VersionDate variables on a single line. Closes #2005.

* #2010 sp_Blitz paused online index operations (#2011)

Add warning for rows in sys.index_resumable_operations. Closes #2010.

* Fix collation error. (#2014)

* #2015 sp_BlitzCache sorting in Azure SQL DB (#2016)

Instead of checking version numbers, look at sys.all_columns for the grant and spill columns. Closes #2015.

* #2024 sp_BlitzQueryStore s.is_cursor error (#2025)

Changed alias on a temp table to match other nearby aliases. Closes #2024.

* First responder consistency check (#1997)

* sp_Blitz update compile and runs on MSSQL 2014

* Update sp_Blitz.sql

Added @debug handling - bug found for missing mandatory component

* Update sp_Blitz.sql

* Update sp_Blitz.sql


CheckId familly:

226 - FRK consistency

Messages:
2260 - First Responder kit consistency check has been unexpectedly modified (check names)
2261 - First Responder kit consistency check has been unexpectedly modified (dynamic query failure)
2262 - First Responder kit mandatory component called %s is missing
2263 - First Responder kit consistency check has been unexpectedly modified (checks ordering)
2264 - Component %s is not at the minimum version required to run this procedure
2265 - First Responder kit consistency check (Failed dynamic SP call to %s)
2266 - First Responder kit consistency: outdated component (%s)

removed "everything ok message"

* Resolves almost all Brent's comments except CHAR(92) change

removed 2264 - Component %s is not at the minimum version required to run this procedure
changed detailled finding message for previous 2264 message

Checked compilation on SQL Server 2014

* #1994 sp_Blitz version checking (#2028)

Changed wording from "consistency check" to "version check," updated check IDs, removed mandatory scripts. Closes #1994.

* #1944 sp_BlitzIndex ignore databases (#2029)

Adds new IgnoreDatabases parameter, and skips databases with >100 partitions. Closes #1944.

* #2009 sp_BlitzFirst call BC differently (#2030)

Use SkipAnalysis = 1, SortOrder = all when calling sp_BlitzCache. Closes #2009.

* #2026 sp_BlitzCache show multiple plan count (#2031)

Closes #2026.

* #2017 sp_Blitz Evaluation Edition expiration check (#2032)

Closes #2017.

* #2018 sp_BlitzCache arith overflow (#2033)

Changing MONEY on totals to BIGINT. Closes #2018.

* #2019 sp_BlitzCache air_quote_actual plans (#2034)

Closes #2019.

* Add END in the right spot for IF @Help = 1 (#2035)

The END for IF @Help = 1 was in the wrong place, making the procedure a no-op *unless* you also specify @Help = 1.

* #2037 sp_BlitzLock support for AWS RDS (#2038)

Skips update stats with options that RDS doesn't support. Closes #2037.

* 2019_04_release_prep

Bumping version numbers, building installation scripts.

* Moved SQL header build outside of If block (#2040)

* #2042 implicit transaction troubleshooting (#2043)

Clarify warnings in sp_Blitz, sp_BlitzFirst. Closes #2042.

* edit hyperlink (#2056)

* add @OutputType = 'XML' (#2048)

* Update sp_blitzcache to avoid arithmetic overflow errors (#2046)

Updated sp_blitzcache to avoid arithmetic overflow errors - tabel definitions had changed to BIGINT but the actual logic in this section still casted values as money which was breaking the ceiling for this on our setup.  I've pretty much blanket chantged everything except averages to be bigint and have been running for a few days with no failrues since so looks ok and worth someone who knows what they're doing casting an eye over it!

* Update sp_ineachdb.sql (#2061)

Added 2 Variables 
@SQLVersion: This was implemented so that large organizations with SQL Server 2008 and R2 can use this sproc.  Currently without this change SQL Server versions 2008 and 2008R2 will error with the following.  Msg 208, Level 16, State 1, Procedure sp_ineachdb, Line 176
Invalid object name 'sys.dm_hadr_database_replica_states'.

@ServerName:  This was added to account for VMware SnapShots at times @@ServerName will either come up NULL or with old server name.  CONVERT(sysname, SERVERPROPERTY('ServerName')) is a better option and reduces minor nuisances.  

Feel free to blend in the code if you feel this brings value to the project.

* ignore readable secondaries in sp_blitzcache (#2049)

* ignore readable secondaries in sp_blitzcache

this is a fix for issue #2027

* Checking for is_primary_replica column

In sys.dm_hadr_database_replica_states.

* 2019_07 Release

Bumping version numbers and updating install scripts.

* Set DBOwner after restoring database (#2082)

* Default @RestoreDiff = NULL
If @RestoreDiff IS NULL and @BackupPathDiff != null: treat RestoreDiff=1

* Set database owner after restore

* Revert restorediff change from dev branch

* Exclude Readable secondary DBs (#2073)

Temp table added (#ReadableDBs) this table is populated with all read intent database id's which is used to filter out these database when querying against dm_exec_requests or sessions with a cross apply against a plan cache function.

* #2067 Updating directory "/" fixing to work with URLs (#2071)

* Updating directory "/" fixing to work with URLs

Also correcting incorrect logging message for fixing @MoveLogDrive slashes

* Fixing variable typo

Data should be log

* #2076 sp_BlitzIndex columnstore to table (#2085)

When saving columnstore definitions to table, trim them to 4000 characters to avoid an overflow. Closes #2076.

* @2060 sp_BlitzFirst 2TB RAM (#2086)

Casting RAM as a BIGINT instead of INT. Closes #2060.

* #2053 sp_BlitzIndex ignoring databases (#2087)

Strip out CR/LF from @IgnoreDatabases, trim spaces afterwards. Closes #2053.

* #2022 sp_BlitzCache disabling air_quote_actuals (#2088)

This SQL 2019 & Azure SQL DB feature isn't ready yet, so disabling til Microsoft is ready. Closes #2022.

* #2044 sp_Blitz new power mode (#2089)

Adds Windows 10's new Ultimate Performance Power Mode, whatever that is. Closes #2044.

* #2062 sp_BlitzFirst false alarm on index reorgs (#2091)

Filtering for sql_text not like %alter index%'. Closes #2062 with duct tape.

* #2052 sp_BlitzCache prioritization (#2092)

Fixes bug in AirQuoteActual plans, plus if plan cache is 75% new as of today, raise priority 1 warning. Closes #2052.

* #2070 sp_BlitzCache duplicated index count (#2093)

Filters index recommendations by spid. Closes #2070.

* sp_DatabaseRestore case bug

Inconsistent case sensitivity.

* 2019-09 release prep

Bumping version numbers and dates.

* 2019-08 release

Updating multi-script installs.
BrentOzar added a commit that referenced this issue Sep 22, 2019
2019-09 Release (#2121)
* #2005 sp_Blitz version numbers (#2006)

Working on #2005.

* #2005 easier merges for versions

Putting Version, VersionDate variables on a single line. Closes #2005.

* #2010 sp_Blitz paused online index operations (#2011)

Add warning for rows in sys.index_resumable_operations. Closes #2010.

* Fix collation error. (#2014)

* #2015 sp_BlitzCache sorting in Azure SQL DB (#2016)

Instead of checking version numbers, look at sys.all_columns for the grant and spill columns. Closes #2015.

* #2024 sp_BlitzQueryStore s.is_cursor error (#2025)

Changed alias on a temp table to match other nearby aliases. Closes #2024.

* First responder consistency check (#1997)

* sp_Blitz update compile and runs on MSSQL 2014

* Update sp_Blitz.sql

Added @debug handling - bug found for missing mandatory component

* Update sp_Blitz.sql

* Update sp_Blitz.sql


CheckId familly:

226 - FRK consistency

Messages:
2260 - First Responder kit consistency check has been unexpectedly modified (check names)
2261 - First Responder kit consistency check has been unexpectedly modified (dynamic query failure)
2262 - First Responder kit mandatory component called %s is missing
2263 - First Responder kit consistency check has been unexpectedly modified (checks ordering)
2264 - Component %s is not at the minimum version required to run this procedure
2265 - First Responder kit consistency check (Failed dynamic SP call to %s)
2266 - First Responder kit consistency: outdated component (%s)

removed "everything ok message"

* Resolves almost all Brent's comments except CHAR(92) change

removed 2264 - Component %s is not at the minimum version required to run this procedure
changed detailled finding message for previous 2264 message

Checked compilation on SQL Server 2014

* #1994 sp_Blitz version checking (#2028)

Changed wording from "consistency check" to "version check," updated check IDs, removed mandatory scripts. Closes #1994.

* #1944 sp_BlitzIndex ignore databases (#2029)

Adds new IgnoreDatabases parameter, and skips databases with >100 partitions. Closes #1944.

* #2009 sp_BlitzFirst call BC differently (#2030)

Use SkipAnalysis = 1, SortOrder = all when calling sp_BlitzCache. Closes #2009.

* #2026 sp_BlitzCache show multiple plan count (#2031)

Closes #2026.

* #2017 sp_Blitz Evaluation Edition expiration check (#2032)

Closes #2017.

* #2018 sp_BlitzCache arith overflow (#2033)

Changing MONEY on totals to BIGINT. Closes #2018.

* #2019 sp_BlitzCache air_quote_actual plans (#2034)

Closes #2019.

* Add END in the right spot for IF @Help = 1 (#2035)

The END for IF @Help = 1 was in the wrong place, making the procedure a no-op *unless* you also specify @Help = 1.

* #2037 sp_BlitzLock support for AWS RDS (#2038)

Skips update stats with options that RDS doesn't support. Closes #2037.

* 2019_04_release_prep

Bumping version numbers, building installation scripts.

* Moved SQL header build outside of If block (#2040)

* #2042 implicit transaction troubleshooting (#2043)

Clarify warnings in sp_Blitz, sp_BlitzFirst. Closes #2042.

* edit hyperlink (#2056)

* add @OutputType = 'XML' (#2048)

* Update sp_blitzcache to avoid arithmetic overflow errors (#2046)

Updated sp_blitzcache to avoid arithmetic overflow errors - tabel definitions had changed to BIGINT but the actual logic in this section still casted values as money which was breaking the ceiling for this on our setup.  I've pretty much blanket chantged everything except averages to be bigint and have been running for a few days with no failrues since so looks ok and worth someone who knows what they're doing casting an eye over it!

* Update sp_ineachdb.sql (#2061)

Added 2 Variables 
@SQLVersion: This was implemented so that large organizations with SQL Server 2008 and R2 can use this sproc.  Currently without this change SQL Server versions 2008 and 2008R2 will error with the following.  Msg 208, Level 16, State 1, Procedure sp_ineachdb, Line 176
Invalid object name 'sys.dm_hadr_database_replica_states'.

@ServerName:  This was added to account for VMware SnapShots at times @@ServerName will either come up NULL or with old server name.  CONVERT(sysname, SERVERPROPERTY('ServerName')) is a better option and reduces minor nuisances.  

Feel free to blend in the code if you feel this brings value to the project.

* ignore readable secondaries in sp_blitzcache (#2049)

* ignore readable secondaries in sp_blitzcache

this is a fix for issue #2027

* Checking for is_primary_replica column

In sys.dm_hadr_database_replica_states.

* 2019_07 Release

Bumping version numbers and updating install scripts.

* Set DBOwner after restoring database (#2082)

* Default @RestoreDiff = NULL
If @RestoreDiff IS NULL and @BackupPathDiff != null: treat RestoreDiff=1

* Set database owner after restore

* Revert restorediff change from dev branch

* Exclude Readable secondary DBs (#2073)

Temp table added (#ReadableDBs) this table is populated with all read intent database id's which is used to filter out these database when querying against dm_exec_requests or sessions with a cross apply against a plan cache function.

* #2067 Updating directory "/" fixing to work with URLs (#2071)

* Updating directory "/" fixing to work with URLs

Also correcting incorrect logging message for fixing @MoveLogDrive slashes

* Fixing variable typo

Data should be log

* #2076 sp_BlitzIndex columnstore to table (#2085)

When saving columnstore definitions to table, trim them to 4000 characters to avoid an overflow. Closes #2076.

* @2060 sp_BlitzFirst 2TB RAM (#2086)

Casting RAM as a BIGINT instead of INT. Closes #2060.

* #2053 sp_BlitzIndex ignoring databases (#2087)

Strip out CR/LF from @IgnoreDatabases, trim spaces afterwards. Closes #2053.

* #2022 sp_BlitzCache disabling air_quote_actuals (#2088)

This SQL 2019 & Azure SQL DB feature isn't ready yet, so disabling til Microsoft is ready. Closes #2022.

* #2044 sp_Blitz new power mode (#2089)

Adds Windows 10's new Ultimate Performance Power Mode, whatever that is. Closes #2044.

* #2062 sp_BlitzFirst false alarm on index reorgs (#2091)

Filtering for sql_text not like %alter index%'. Closes #2062 with duct tape.

* #2052 sp_BlitzCache prioritization (#2092)

Fixes bug in AirQuoteActual plans, plus if plan cache is 75% new as of today, raise priority 1 warning. Closes #2052.

* #2070 sp_BlitzCache duplicated index count (#2093)

Filters index recommendations by spid. Closes #2070.

* sp_DatabaseRestore case bug

Inconsistent case sensitivity.

* 2019-09 release prep

Bumping version numbers and dates.

* 2019-08 release

Updating multi-script installs.

* #2097 sp_DatabaseRestore sysname caps (#2100)

Change from uppercase to lowercase for case-sensitive systems. Closes #2097.

* Issue 2063 selects with writes (#2101)

* Update sp_BlitzCache.sql

Adds check for selects that cause writes.

* Update BC docs

Adds a line to the documentation for BlitzCache, tidies up warning table message.

* Fix compression query perf (#2103)

Breaking this up into #temp tables has made it much faster on servers with many partitions.

* Issue 2051 query hash sort (#2102)

* Add query hash sort order

Grabs top10 highest cpu consuming plans with highest count of query hashes (multiple plans), and runs BlitsCache to find them.

* add a word

why not?

* Tweaks for query hash

* URL housekeeping (#2098)

* New Zealand is a real place and it's offensive for you to suggest otherwise 🥝

* revert edits to Install* scripts

* #2111 sp_BlitzCache missing union all (#2112)

Cleans up the documentation, closes #2111.

* Added Uninstaller Script (#2105)

* Added Uninstaller Script

Fulfills request #2080

Deletes all the FirstResponderKit procedures from the current DB or all DBs via parameter

* Case sensitive collation fixes

Gotta love those case sensitive servers.

* Remove stray semicolon (#2115)

Closes #2114 

Semicolon throws syntax error.

* Fix roll up where clause (#2116)

Closes #2113 

Where clause should only look at flagged lines.

* #2096 sp_BlitzFirst BST compatibility (#2117)

Not really about BST, heh, but just using the wrong date/time format. Closes #2096.

* 2109_sp_BlitzCache_AirQuoteActuals (#2118)

If the AirQuoteActual plan is longer than the regular plan, use it. Closes #2109.

* #2119 2019-09 release prep (#2120)

Bumping version numbers, dates, install scripts. Closes #2119.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.