Update agent framework structure #43
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Copyright 2025 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| /** | ||
| * Utility to manage scroll pin-to-bottom behavior for a scrollable container. | ||
| */ | ||
| export class ScrollPinHelper { | ||
| #el: HTMLElement | null = null; | ||
| #scrollTop?: number; | ||
| #pinToBottom = true; | ||
| #isProgrammatic = false; | ||
| static readonly ROUNDING_OFFSET = 1; | ||
|
|
||
| setElement(el: HTMLElement | undefined): void { | ||
| if (el) { | ||
| this.#el = el; | ||
| } else { | ||
| this.#el = null; | ||
| this.#pinToBottom = true; | ||
| } | ||
| } | ||
|
|
||
| handleResize(): void { | ||
| if (!this.#el) return; | ||
| if (this.#pinToBottom) { | ||
| this.setScrollTop(this.#el.scrollHeight); | ||
| } | ||
| } | ||
|
|
||
| handleScroll(target: HTMLElement): void { | ||
| if (this.#isProgrammatic) { | ||
| this.#isProgrammatic = false; | ||
| return; | ||
| } | ||
| this.#scrollTop = target.scrollTop; | ||
| this.#pinToBottom = target.scrollTop + target.clientHeight + ScrollPinHelper.ROUNDING_OFFSET > target.scrollHeight; | ||
| } | ||
|
|
||
| setScrollTop(value: number): void { | ||
| if (!this.#el) return; | ||
| this.#scrollTop = value; | ||
| this.#isProgrammatic = true; | ||
| this.#el.scrollTop = value; | ||
| } | ||
|
|
||
| scrollToBottom(): void { | ||
| if (!this.#el) return; | ||
| this.setScrollTop(this.#el.scrollHeight); | ||
| } | ||
|
|
||
| restoreLastPosition(): void { | ||
| if (this.#scrollTop === undefined) { | ||
| return; | ||
| } | ||
| this.setScrollTop(this.#scrollTop); | ||
| } | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
New AI Chat UI files added to GRD manifest — ensure files exist.
Good additions. Please verify the files exist at these paths (case and subdir correctness), otherwise grd gen will break.
🏁 Script executed:
Length of output: 1412
Correct missing AI Chat UI component entries in
config/gni/devtools_grd_files.gni.The manifest lists these files, but none exist at the given paths—update to the actual filenames (e.g.
.tsxextensions) or remove the invalid entries:🤖 Prompt for AI Agents