Chrome dev tools main

.gn

@@ -1,4 +1,4 @@
-# Copyright 2019 the V8 project authors. All rights reserved.
+# Copyright 2019 The Chromium Authors
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 

.vscode/devtools-workspace-launch.json

@@ -1,43 +1,25 @@
 {
   "version": "0.2.0",
   "configurations": [
-    {
-      "type": "chrome",
-      "request": "launch",
-      "name": "Run unit tests in VS Code debugger",
-      "preLaunchTask": "1-build_Debug",
-      "runtimeExecutable": "npm",
-      "runtimeArgs": ["run", "test", "front_end"],
-      "port": 7722,
-      "timeout": 30000,
-      "browserLaunchLocation": "workspace",
-      "outputCapture": "std",
-      "trace": true
-    },
-    {
-      "type": "node",
-      "request": "launch",
-      "name": "Run end-to-end tests in VS Code debugger",
-      "preLaunchTask": "1-build_Debug",
-      "runtimeExecutable": "npm",
-      "runtimeArgs": ["run", "test", "test/e2e"]
-    },
     {
       "type": "node",
       "request": "launch",
-      "name": "Run test",
+      "name": "Run current test file",
       "cwd": "${workspaceFolder}",
       "runtimeExecutable": "npm",
       "runtimeArgs": ["run", "test", "--", "${file}"]
     },
     {
       "type": "node",
       "request": "launch",
-      "name": "Debug test",
+      "name": "Debug current test file",
       "cwd": "${workspaceFolder}",
       "runtimeExecutable": "npm",
       "console": "integratedTerminal",
-      "runtimeArgs": ["run", "test", "--", "--debug", "${file}"]
+      "runtimeArgs": ["run", "test", "--", "--debug", "${file}"],
+      "env": {
+        "VSCODE_DEBUGGER": true
+      }
     }
   ]
 }

AUTHORS

@@ -14,6 +14,7 @@
 AbdAlRahman Gad <abdobngad@gmail.com>
 Ajay Panthagani <ajaypanthagani321@gmail.com>
 Alesandro Ortiz <alesandro@alesandroortiz.com>
+Alex Ho <wjhe1016@gmail.com>
 Alexander Stammbach <alexander@stammbach.io>
 Alexey Rodionov <fluorescent.hallucinogen@gmail.com>
 Ameen Basha <ameenbasha111@gmail.com>

DEPS

@@ -12,27 +12,27 @@ vars = {
   'build_with_chromium': False,
 
   'build_url': 'https://chromium.googlesource.com/chromium/src/build.git',
-  'build_revision': '7133d7642a7f3a61dd3154f8685a6018c1f159a0',
+  'build_revision': 'dd54bc718b7c5363155660d12b7965ea9f87ada9',
 
   'buildtools_url': 'https://chromium.googlesource.com/chromium/src/buildtools.git',
-  'buildtools_revision': '958004daacdd90070d44b236a1581c81d71740ca',
+  'buildtools_revision': '88a3274e7b0c6314c84ed202ee6377d1cf9e22b0',
 
   'depot_tools_url': 'https://chromium.googlesource.com/chromium/tools/depot_tools.git',
-  'depot_tools_revision': '3accee0833540add4e5e608d222e01a768d9f94e',
+  'depot_tools_revision': '73e46667ed3a1326cf564747737b4e11137d7f29',
 
   'inspector_protocol_url': 'https://chromium.googlesource.com/deps/inspector_protocol',
-  'inspector_protocol_revision': '07272ab9a30fd555890fda0718f4c2c25931653a',
+  'inspector_protocol_revision': '1ac1ec6d0c61c081cc73793e491b987beecccde1',
 
   # Keeping track of the last time we rolled the browser protocol files.
-  'chromium_browser_protocol_revision' : 'a0857bc5fc46c520d7fe71beb1b0a0d7b0e60136',
+  'chromium_browser_protocol_revision' : 'c0cd408650a942d836b07c15facd3f4fede1d578',
 
   'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
   'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',
 
   'emscripten_tag': 'ade9d780ff17c88d81aa13860361743e3c1e1396',
 
   # GN CIPD package version.
-  'gn_version': 'git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d',
+  'gn_version': 'git_revision:81b24e01531ecf0eff12ec9359a555ec3944ec4e',
 
   'cmake_version': 'version:2@3.21.3',
 
@@ -49,7 +49,7 @@ vars = {
   # Chrome version used for tests. It should be regularly updated to
   # match the Canary version listed here:
   # https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
-  'chrome': '142.0.7409.0',
+  'chrome': '142.0.7439.0',
 
   # 'magic' text to tell depot_tools that git submodules should be accepted but
   # but parity with DEPS file is expected.
@@ -59,7 +59,7 @@ vars = {
   'non_git_source': 'True',
 
   # siso CIPD package version
-  'siso_version': 'git_revision:02cbec18d7b18a0733fec402f2e90ff071b98f63',
+  'siso_version': 'git_revision:acfc39d4c923834851300e8676daf8fc47e53a2d',
 }
 
 # Only these hosts are allowed for dependencies in this DEPS file.

PRESUBMIT.py

@@ -13,6 +13,7 @@
 `git cl presubmit -v -v` to debug presubmit checks.
 """
 
+import re
 import sys
 import six
 import time
@@ -27,16 +28,24 @@
     r'^front_end[\\/]core[\\/]common[\\/]Color\.ts$',  # Apple copyright
     r'^front_end[\\/]core[\\/]common[\\/]Object\.ts$',  # Apple copyright
     r'^front_end[\\/]core[\\/]common[\\/]ResourceType\.ts$',  # Apple copyright
-    r'^front_end[\\/]core[\\/]dom_extension[\\/]DOMExtension\.ts$',  # Apple copyright
+    # Apple copyright
+    r'^front_end[\\/]core[\\/]dom_extension[\\/]DOMExtension\.ts$',
     r'^front_end[\\/]core[\\/]platform[\\/]UIString\.ts$',  # Apple copyright
     r'^front_end[\\/]core[\\/]sdk[\\/]Resource\.ts$',  # Apple copyright
     r'^front_end[\\/]core[\\/]sdk[\\/]Script\.ts$',  # Apple copyright
-    r'^front_end[\\/]ui[\\/]legacy[\\/]components[\\/]data_grid[\\/]DataGrid\.ts$',  # Apple copyright
+    r'^front_end[\\/]third_party[\\/].*',  # 3rd party code
+    # Apple copyright
+    r'^front_end[\\/]ui[\\/]legacy[\\/]components[\\/]data_grid[\\/]DataGrid\.ts$',
+    r'^node_modules[\\/].*',  # 3rd party code
     r'^scripts[\\/]build[\\/]build_inspector_overlay\.py$',  # Lines too long
     r'^scripts[\\/]build[\\/]code_generator_frontend\.py$',
     r'^scripts[\\/]deps[\\/]manage_node_deps\.py$',  # Lines too long
+    r'front_end[\\/]generated[\\/]ARIAProperties\.ts$'  # Auto-generated files
+    # Auto-generated files
+    r'front_end[\\/]generated[\\/]InspectorBackendCommands\.ts$'
 ]
 
+
 def _ExecuteSubProcess(input_api,
                        output_api,
                        script_path,
@@ -246,13 +255,7 @@ def CheckDevToolsLint(input_api, output_api):
     ]
 
     lint_related_directories = [
-        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules',
-                               'eslint'),
-        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules',
-                               'stylelint'),
-        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules',
-                               '@typescript-eslint'),
-        input_api.os_path.join(scripts_directory, 'eslint_rules'),
+        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules'),
     ]
 
     lint_config_files = _GetAffectedFiles(
@@ -400,9 +403,38 @@ def CheckNodeModules(input_api, output_api):
         if not Path(file_path).is_file():
             results.extend([
                 output_api.PresubmitError(
-                    "node_modules/%s is missing. Use npm run install-deps to re-create it."
+                    "node_modules/%s is missing. Use `npm run install-deps` to re-create it."
                     % file)
             ])
+
+    node_module_files = _GetAffectedFiles(input_api, [
+        input_api.os_path.join(input_api.PresubmitLocalPath(), 'node_modules')
+    ], [], [])
+
+    # If the changes are above 100 assume that touching the node_modules
+    # was intentional
+    if len(node_module_files) == 0 or len(node_module_files) > 100:
+        return results
+
+    message = (
+        "Changes to `node_modules` detected.\n" +
+        "This is third party code and should not be modified.\n" +
+        "`node_module` are mainly used in testing infra\n" +
+        "For bug fixes and features usually you should not need this change.\n"
+        + "Was this change intentional?")
+    results.extend([
+        output_api.PresubmitPromptWarning(
+            message,
+            locations=[
+                output_api.PresubmitResultLocation(
+                    # Location expects relative path
+                    # But _GetAffectedFiles returns us absolute path
+                    input_api.os_path.relpath(
+                        node_module_files[0],
+                        input_api.PresubmitLocalPath()), ),
+            ])
+    ])
+
     return results
 
 
@@ -416,7 +448,7 @@ def CheckNoUncheckedFiles(input_api, output_api):
     out, _ = process.communicate()
     if process.returncode != 0:
         files_changed_process = input_api.subprocess.Popen(
-            ['git', 'diff', '--name-only'],
+            ['git', 'diff'],
             stdout=input_api.subprocess.PIPE,
             stderr=input_api.subprocess.STDOUT)
         files_changed, _ = files_changed_process.communicate()
@@ -430,6 +462,50 @@ def CheckNoUncheckedFiles(input_api, output_api):
     return []
 
 
+def CheckKnownContextValues(input_api, output_api):
+    """Ensure all additions to `KnownContextValues.ts` following the naming convention.
+
+    This check ensures that all new cases added to the enum in `KnownContextValues.ts`
+    follow the extended Kebab Case naming convention. Specifically it doesn't look at
+    unchanged lines, because there are various existing values that cannot be changed
+    (easily).
+    """
+    # This regexp matches the one we use in `StringUtilities.isExtendedKebabCase()`.
+    kebab_case_re = re.compile(
+        r"^([a-z0-9]+(?:-[a-z0-9]+)*\.)*[a-z0-9]+(?:-[a-z0-9]+)*$")
+    local_path = input_api.os_path.join('front_end', 'ui', 'visual_logging',
+                                        'KnownContextValues.ts')
+    invalid_contexts = []
+    for f in filter(
+            lambda x: (x.LocalPath() == local_path and x.Action() == 'M'),
+            input_api.AffectedFiles()):
+        # Loop only through the changed lines of the affected file.
+        for _, line in f.ChangedContents():
+            match = re.search(r"\s+'(.+)',", line)
+            if match:
+                context = match.group(1)
+                if not kebab_case_re.match(context):
+                    invalid_contexts.append(context)
+                    continue
+
+    if not invalid_contexts:
+        return []
+    return [
+        output_api.PresubmitError(
+            message=f"Invalid jslog context(s): {', '.join(invalid_contexts)}",
+            long_text=
+            ("""The jslog contexts must follow the extended Kebab Case naming convention, where
+words are separated with either a dash (`-`) or a dot (`.`), and all characters
+must be lower-case alphanumeric.
+"""),
+            locations=[
+                output_api.PresubmitResultLocation(file_path=local_path)
+            ],
+        )
+    ]
+
+
+
 # Canned check wrappers below.
 
 
@@ -466,7 +542,6 @@ def CheckGenderNeutral(input_api, output_api):
     return input_api.canned_checks.CheckGenderNeutral(input_api, output_api)
 
 
-
 def CheckAuthorizedAuthor(input_api, output_api):
     return input_api.canned_checks.CheckAuthorizedAuthor(
         input_api,

build_overrides/build.gni

@@ -1,4 +1,4 @@
-# Copyright 2016 The Chromium project authors. All rights reserved.
+# Copyright 2016 The Chromium Authors
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 

config/gni/devtools_grd_files.gni

@@ -164,7 +164,8 @@ grd_files_bundled_sources = [
   "front_end/Images/frame-crossed.svg",
   "front_end/Images/frame-icon.svg",
   "front_end/Images/frame.svg",
-  "front_end/Images/gdp-logo-standalone.svg",
+  "front_end/Images/gdp-logo-dark.png",
+  "front_end/Images/gdp-logo-light.png",
   "front_end/Images/gear-filled.svg",
   "front_end/Images/gear.svg",
   "front_end/Images/gears.svg",
@@ -1063,6 +1064,7 @@ grd_files_unbundled_sources = [
   "front_end/core/sdk/CSSQuery.js",
   "front_end/core/sdk/CSSRule.js",
   "front_end/core/sdk/CSSScope.js",
+  "front_end/core/sdk/CSSStartingStyle.js",
   "front_end/core/sdk/CSSStyleDeclaration.js",
   "front_end/core/sdk/CSSStyleSheetHeader.js",
   "front_end/core/sdk/CSSSupports.js",
@@ -1186,6 +1188,9 @@ grd_files_unbundled_sources = [
   "front_end/models/ai_assistance/data_formatters/UnitFormatters.js",
   "front_end/models/ai_assistance/debug.js",
   "front_end/models/ai_assistance/injected.js",
+  "front_end/models/ai_assistance/performance/AICallTree.js",
+  "front_end/models/ai_assistance/performance/AIContext.js",
+  "front_end/models/ai_assistance/performance/AIQueries.js",
   "front_end/models/ai_code_completion/AiCodeCompletion.js",
   "front_end/models/ai_code_completion/debug.js",
   "front_end/models/autofill_manager/AutofillManager.js",
@@ -1443,6 +1448,7 @@ grd_files_unbundled_sources = [
   "front_end/panels/ai_assistance/components/ExploreWidget.js",
   "front_end/panels/ai_assistance/components/MarkdownRendererWithCodeBlock.js",
   "front_end/panels/ai_assistance/components/ScrollPinHelper.js",
+  "front_end/panels/ai_assistance/components/PerformanceAgentMarkdownRenderer.js",
   "front_end/panels/ai_assistance/components/UserActionRow.js",
   "front_end/panels/ai_assistance/components/chatView.css.js",
   "front_end/panels/ai_assistance/components/exploreWidget.css.js",
@@ -2214,14 +2220,10 @@ grd_files_unbundled_sources = [
   "front_end/panels/timeline/timelineSelectorStatsView.css.js",
   "front_end/panels/timeline/timelineStatusDialog.css.js",
   "front_end/panels/timeline/timelineTreeView.css.js",
-  "front_end/panels/timeline/utils/AICallTree.js",
-  "front_end/panels/timeline/utils/AIContext.js",
   "front_end/panels/timeline/utils/EntryNodes.js",
-  "front_end/panels/timeline/utils/FreshRecording.js",
   "front_end/panels/timeline/utils/Helpers.js",
   "front_end/panels/timeline/utils/IgnoreList.js",
   "front_end/panels/timeline/utils/ImageCache.js",
-  "front_end/panels/timeline/utils/InsightAIContext.js",
   "front_end/panels/timeline/utils/Treemap.js",
   "front_end/panels/web_audio/WebAudioModel.js",
   "front_end/panels/web_audio/WebAudioView.js",
@@ -2234,6 +2236,7 @@ grd_files_unbundled_sources = [
   "front_end/panels/whats_new/releaseNoteView.css.js",
   "front_end/services/puppeteer/PuppeteerConnection.js",
   "front_end/services/trace_bounds/TraceBounds.js",
+  "front_end/services/tracing/FreshRecording.js",
   "front_end/services/tracing/PerformanceTracing.js",
   "front_end/services/tracing/TracingManager.js",
   "front_end/services/window_bounds/WindowBoundsService.js",

config/gni/devtools_image_files.gni

@@ -18,6 +18,8 @@ devtools_image_files = [
   "toolbarResizerVertical.png",
   "touchCursor_2x.png",
   "touchCursor.png",
+  "gdp-logo-light.png",
+  "gdp-logo-dark.png",
 ]
 
 devtools_svg_sources = [
@@ -166,7 +168,6 @@ devtools_svg_sources = [
   "frame-crossed.svg",
   "frame-icon.svg",
   "frame.svg",
-  "gdp-logo-standalone.svg",
   "gear-filled.svg",
   "gear.svg",
   "gears.svg",

config/owner/COMMON_OWNERS

@@ -1,6 +1,5 @@
 file://config/owner/ENG_REVIEW_OWNERS
 
-aixba@chromium.org
 alexrudenko@chromium.org
 alinavarkki@chromium.org
 andoli@chromium.org
@@ -16,8 +15,8 @@ kprokopenko@chromium.org
 leese@chromium.org
 mathias@chromium.org
 nancyly@chromium.org
-nechaev@chromium.org
 nharshunova@chromium.org
+nroscino@chromium.org
 nvitkov@chromium.org
 paulirish@chromium.org
 petermueller@chromium.org

config/typescript/tsconfig.eslint.json

@@ -1,7 +1,18 @@
 {
   "extends": "./tsconfig.base.json",
   "compilerOptions": {
-    "lib": ["esnext", "dom", "dom.iterable", "webworker", "webworker.iterable"],
+    "target": "ES2023",
+    "lib": [
+      "ES2023",
+      "ES2024.Promise",
+      "ESNext.Iterator",
+      "ESNext.Collection",
+      "ESNext.Array",
+      "dom",
+      "dom.iterable",
+      "webworker",
+      "webworker.iterable"
+    ],
     "outDir": "ignored-for-vscode"
   },
   "include": [