New windowing tracker and large refactor of IconTasklist (#553)

* windowing: Start work on new window tracker Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * windowing: Handle fullscreen state tracking for windows Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * [WIP] icon-tasklist: Begin port to libxfce4windowing Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * windowing: Add functions to get all groups and the active workspace Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * lib: Add desktop actions field to Budgie.Application Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Add new replacement GTK widgets using Windowing Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Move button geometry to it's own function and fix parameter Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Implement drawing the button indicators Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Make it compile Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Fix showing of popovers Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Implement handling left click on buttons Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Implement launching pinned apps Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * windowing, icon-tasklist: Implement adding and removing buttons when windows open and close This sadly requires using Wnck/X11 specific APIs, and there really is no way around that unless we separate pinned launchers from running applications. But hey, it works! Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Fix button sizing Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * windowing: Fix tracking of active windows Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Implement scroll wheel handling for buttons Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Fix most of the styling with icon button popovers Also fixes new window detection for the popover. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Window indicator enhancements - Move indicators away from the edge slightly - Increase spacing for inactive window indicators - Clean up and document (mostly) the code The aim is to increase the indicator visibility. Before, the indicators were half off the screen, making them hard to see with certain themes. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Hook up new window and close all buttons in popover Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Fix launch animation stopping immedietly Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Hook up pinning button functionality Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Implement icon reordering Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Reset button popover view on hide Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Make popover window control buttons start-aligned Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Dynamically create move to workspace buttons Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * windowing: Rebroadcast signals for workspace creation and deletion Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Popover cleanup Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Implement handling when a window becomes urgent Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Attempt to fix drag and drop for all scenarios Spoiler: Doesn't work. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Make indicator colors more like the old version Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Both dragging tasklist icons and desktop infos work now Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Fix launcher not being removed when unpinned Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * windowing/icon-tasklist: Correctly only show buttons on workspaces when pref is set Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Cleanup Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Implement setting button tooltips Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Move button event handling to the main applet class This will make it easier to implement the rest of the settings. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Implement settings for launching apps Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Cleanup Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Hook up lock-icons setting Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Implement show all windows on click setting Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Remove unused files Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * windowing: Improve reliability of getting DesktopAppInfos for certain applications Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * fix: do not have Budgie.Application be mandatory, rebase on new x4w This should fix applications like Cinny and glxgears from not showing up in IconTasklist * Apply suggestions from code review Co-authored-by: Joshua Strobl <JoshStrobl@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Joshua Strobl <JoshStrobl@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Joshua Strobl <JoshStrobl@users.noreply.github.com> * fix: compilation * feat: implement budgie-app-(un)favorited vectors for use with ButtonPopover * feat: clean up animations, change weird casing of widgets * fix: remove extraneous TODO * fix: left-align action button labels * feat: implemented DESKTOP_IDS_TO_FORCE_WG_ICON to handle edge cases where we should not prefer app icon * Revert "feat: implemented DESKTOP_IDS_TO_FORCE_WG_ICON to handle edge cases where we should not prefer app icon" This reverts commit 32527ed. * windowing: Resolve remaining TODO items Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> * icon-tasklist: Update tooltip for pin button based on pin status Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> --------- Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net> Co-authored-by: Joshua Strobl <me@joshuastrobl.com> Co-authored-by: Joshua Strobl <JoshStrobl@users.noreply.github.com>
BuddiesOfBudgie · Apr 16, 2024 · bf436db · bf436db
1 parent bfab2ff
commit bf436db
Show file tree

Hide file tree

Showing 28 changed files with 2,697 additions and 2,348 deletions.
diff --git a/data/icons/meson.build b/data/icons/meson.build
@@ -26,6 +26,8 @@ app_icons = [
 status_icons = [
     join_paths('.', 'status', 'num-lock-symbolic.svg'),
     join_paths('.', 'status', 'caps-lock-symbolic.svg'),
+    join_paths('.', 'status', 'budgie-app-favorited.svg'),
+    join_paths('.', 'status', 'budgie-app-unfavorited.svg'),
     join_paths('.', 'status', 'budgie-caffeine-cup-full.svg'),
     join_paths('.', 'status', 'budgie-caffeine-cup-empty.svg'),
 ]

diff --git a/data/icons/status/budgie-app-favorited.svg b/data/icons/status/budgie-app-favorited.svg
diff --git a/data/icons/status/budgie-app-unfavorited.svg b/data/icons/status/budgie-app-unfavorited.svg
diff --git a/src/appindexer/meson.build b/src/appindexer/meson.build
@@ -2,10 +2,8 @@ subdir('fuzzer')
 
 appindexer_sources = [
     'AppIndex.vala',
-    'Application.vala',
     'Category.vala',
     'RelevancyService.vala',
-    'Switcheroo.vala'
 ]
 
 libappindexer = shared_library(
@@ -16,6 +14,9 @@ libappindexer = shared_library(
         dep_giounix,
         dep_gtk3,
         link_libfuzzer,
+        libpanelplugin_vapi,
+        link_libpanelplugin,
+        link_libbudgieprivate,
     ],
     vala_args: [
         '--pkg', 'gtk+-3.0',

diff --git a/src/dialogs/run/meson.build b/src/dialogs/run/meson.build
@@ -8,6 +8,9 @@ rundialog_deps = [
     dep_gee,
     dep_giounix,
     dep_gtk3,
+    libpanelplugin_vapi,
+    link_libpanelplugin,
+    link_libbudgieprivate,
     link_libappindexer,
     link_libconfig,
     link_libtheme,

diff --git a/src/lib/animation.vala b/src/lib/animation.vala
@@ -127,62 +127,17 @@ namespace Budgie {
 	* and are available under the terms of the WTFPL
 	*/
 
-	public static double sine_ease_in_out(double p) {
-		return 0.5 * (1 - Math.cos(p * Math.PI));
-	}
-
 	public static double sine_ease_in(double p) {
 		return Math.sin((p - 1) * Math.PI_2) + 1;
 	}
 
-	public static double sine_ease_out(double p) {
-		return Math.sin(p * Math.PI_2);
-	}
-
-	public static double elastic_ease_in(double p) {
-		return Math.sin(13 * Math.PI_2 * p) * Math.pow(2, 10 * (p - 1));
-	}
-
 	public static double elastic_ease_out(double p) {
 		return Math.sin(-13 * Math.PI_2 * (p + 1)) * Math.pow(2, -10 * p) + 1;
 	}
 
-	public static double back_ease_in(double p) {
-		return p * p * p - p * Math.sin(p * Math.PI);
-	}
-
-	public static double back_ease_out(double p) {
-		double f = (1 - p);
-		return 1 - (f * f * f - f * Math.sin(f * Math.PI));
-	}
-
-	public static double expo_ease_in(double p) {
-		return (p == 0.0) ? p : Math.pow(2, 10 * (p - 1));
-	}
-
 	public static double expo_ease_out(double p) {
 		return (p == 1.0) ? p : 1 - Math.pow(2, -10 * p);
 	}
 
-	public static double quad_ease_in(double p) {
-		return p * p;
-	}
-
-	public static double quad_ease_out(double p) {
-		return -(p * (p - 2));
-	}
-
-	public static double quad_ease_in_out(double p) {
-		return p < 0.5 ? (2 * p * p) : (-2 * p * p) + (4 * p) - 1;
-	}
-
-	public static double circ_ease_in(double p) {
-		return 1 - Math.sqrt(1 - (p * p));
-	}
-
-	public static double circ_ease_out(double p) {
-		return Math.sqrt((2 - p) * p);
-	}
-
 	public const int64 MSECOND = 1000;
 }
diff --git a/src/appindexer/Application.vala → src/lib/application.vala b/src/appindexer/Application.vala → src/lib/application.vala
@@ -27,6 +27,7 @@ namespace Budgie {
 		public bool prefers_default_gpu { get; private set; default = false; }
 		public bool should_show { get; private set; default = true; }
 		public bool dbus_activatable { get; private set; default = false; }
+		public unowned string[] actions { get; private set; }
 
 		/**
 		 * Emitted when the application is launched.
@@ -60,6 +61,7 @@ namespace Budgie {
 			this.prefers_default_gpu = !app_info.get_boolean("PrefersNonDefaultGPU");
 			this.should_show = app_info.should_show();
 			this.dbus_activatable = app_info.get_boolean("DBusActivatable");
+			this.actions = app_info.list_actions();
 
 			// Try to get an icon from the desktop file
 			var desktop_icon = app_info.get_icon();
@@ -76,13 +78,36 @@ namespace Budgie {
 			this.switcheroo = new Switcheroo();
 		}
 
+		public AppLaunchContext create_launch_context() {
+			// Create a launch context and try to apply a GPU profile
+			var context = new AppLaunchContext();
+
+			// Hook up our signals for rebroadcast
+			context.launched.connect((info, data) => {
+				this.launched(info, data);
+			});
+			context.launch_failed.connect((startup_id) => {
+				this.launch_failed(startup_id);
+			});
+
+			// Try to apply a GPU profile if necessary for multiple GPU setups
+			switcheroo.apply_gpu_profile(context, this.prefers_default_gpu);
+
+			return context;
+		}
+
+		public bool launch() {
+			var context = create_launch_context();
+			return launch_with_context(context);
+		}
+
 		/**
 		* Launch this application.
 		*
 		* Returns `true` if the application launched successfully,
 		* otherwise `false`.
 		*/
-		public bool launch() {
+		public bool launch_with_context(AppLaunchContext context) {
 			try {
 				var info = new DesktopAppInfo(this.desktop_id);
 				/*
@@ -117,21 +142,6 @@ namespace Budgie {
 					});
 				} else {
 					// No pkexec, use the DesktopAppInfo to launch the app
-					// Create a launch context and try to apply a GPU profile
-					var context = new AppLaunchContext();
-
-					// Hook up our signals for rebroadcast
-					context.launched.connect((info, data) => {
-						this.launched(info, data);
-					});
-					context.launch_failed.connect((startup_id) => {
-						this.launch_failed(startup_id);
-					});
-
-					// Try to apply a GPU profile if necessary for multiple GPU setups
-					switcheroo.apply_gpu_profile(context, this.prefers_default_gpu);
-
-					// Launch the application
 					new DesktopAppInfo(this.desktop_id).launch(null, context);
 				}
 			} catch (Error e) {
@@ -141,5 +151,21 @@ namespace Budgie {
 
 			return true;
 		}
+
+		/**
+		* Launch this application with the given action.
+		*/
+		public void launch_action(string action) {
+			var context = create_launch_context();
+
+			launch_action_with_context(action, context);
+		}
+
+		/**
+		* Launch this application with the given action and launch context.
+		*/
+		public void launch_action_with_context(string action, AppLaunchContext context) {
+			new DesktopAppInfo(this.desktop_id).launch_action(action, context);
+		}
 	}
 }
diff --git a/src/lib/meson.build b/src/lib/meson.build
@@ -2,10 +2,12 @@
 
 libbudgieprivate_sources = [
     'animation.vala',
+    'application.vala',
     'toplevel.vala',
     'shadow.vala',
     'manager.vala',
-    'notification.vala'
+    'notification.vala',
+    'switcheroo.vala',
 ]
 
 libbudgieprivate = shared_library(

diff --git a/src/appindexer/Switcheroo.vala → src/lib/switcheroo.vala b/src/appindexer/Switcheroo.vala → src/lib/switcheroo.vala
diff --git a/src/meson.build b/src/meson.build
@@ -6,13 +6,14 @@ subdir('config')
 subdir('libsession')
 
 # Needed for daemon + applets
-subdir('appindexer')
 subdir('appsys')
 subdir('abomination')
 
 subdir('theme')
 subdir('lib')
 subdir('raven')
+subdir('windowing')
+subdir('appindexer')
 
 # Executable components
 subdir('daemon')

diff --git a/src/panel/applets/budgie-menu/BudgieMenuButtons.vala b/src/panel/applets/budgie-menu/BudgieMenuButtons.vala
@@ -69,7 +69,7 @@ public class MenuButton : Gtk.Button {
 			hexpand = true,
 		};
 
-		const Gtk.TargetEntry[] drag_targets = { {"text/uri-list", 0, 0 }, {"application/x-desktop", 0, 0 } };
+		const Gtk.TargetEntry[] drag_targets = { {"text/uri-list", 0, 0 } };
 		Gtk.drag_source_set(this, Gdk.ModifierType.BUTTON1_MASK, drag_targets, Gdk.DragAction.COPY);
 		base.drag_begin.connect(this.drag_begin);
 		base.drag_end.connect(this.drag_end);

diff --git a/src/panel/applets/budgie-menu/meson.build b/src/panel/applets/budgie-menu/meson.build
@@ -48,8 +48,9 @@ applet_budgiemenu_deps = [
     dep_peas,
     dep_accountsservice,
     dep_cairo,
-    link_libappindexer,
     link_libpanelplugin,
+    link_libbudgieprivate,
+    link_libappindexer,
 ]
 
 shared_library(

diff --git a/src/panel/applets/icon-tasklist/DesktopHelper.vala b/src/panel/applets/icon-tasklist/DesktopHelper.vala