Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli option for focus_quit field #424 #572

Merged
merged 1 commit into from
May 13, 2024

Conversation

voidpointer0x00
Copy link
Contributor

Description

Added a cli option to disable focus_quit that would close budgie-run-dialog when loosing focus. Without the argument it's set to false, leaving the default behavior unchanged.

Application Options:
  -f, --focus-keep     Do not quit when out of focus

CLI options parsing was implemented the same way sendto Application.vala does it.

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

@voidpointer0x00 voidpointer0x00 changed the title feat: cli option for focus_quit field (#424) feat: cli option for focus_quit field #424 May 10, 2024
@JoshStrobl JoshStrobl self-requested a review May 13, 2024 06:18
@JoshStrobl
Copy link
Member

JoshStrobl commented May 13, 2024

Could you explain your usecase as to why you want to keep Budgie Run Dialog open?

@voidpointer0x00
Copy link
Contributor Author

Could you explain your usecase as to why you want to keep Budgie Run Dialog open?

Yep, it's here #424

@JoshStrobl
Copy link
Member

Ah yea sorry, checked this pre-coffee 🤦

PR looks good to me, thanks!

@JoshStrobl JoshStrobl added this to the 10.10 milestone May 13, 2024
@JoshStrobl JoshStrobl merged commit 6e91c81 into BuddiesOfBudgie:main May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants