Don't show tabswitcher if window is empty #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When pressing Alt-Tab with no active windows, the tabswitcher window still appears. No icons are displayed and the window title is either blank, or the last window selected via alt-tab. It appears this is due to the window being set to show on the keypress regardless of the number of active children.
This PR would address this by making the "get_visible_children" public so the DBus function can check if there are items in the tabswitcher window before showing the window. Since this function already takes into consideration the "Show all windows in tab switcher" setting in BDS, it ensures the tab switcher will still work correctly with this setting on or off.
Closes #578
Submitter Checklist
git rebase -i(if needed)