icons: Use the correct name for the reboot icon #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would link to the spec, but the Freedesktop Gitlab is currently being upgraded, so it isn't accessible. |
According to the icon naming spec, the correct name to use for a reboot icon is `system-reboot` (and thus, `system-reboot-symbolic` for symbolic). Before this, we were using `system-restart-symbolic`, and had to provide an icon for this. This change increases compatibility with other icon themes, including Breeze, while retaining our own icon in case a theme does not provide it. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
JoshStrobl
force-pushed
the
use-correct-names-for-reboot-icons
branch
from
369b03e to
9aadcfc
Compare
JoshStrobl
pushed a commit
that referenced
this pull request
Jun 21, 2024
According to the icon naming spec, the correct name to use for a reboot icon is `system-reboot` (and thus, `system-reboot-symbolic` for symbolic). Before this, we were using `system-restart-symbolic`, and had to provide an icon for this. This change increases compatibility with other icon themes, including Breeze, while retaining our own icon in case a theme does not provide it. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the icon naming spec, the correct name to use for a reboot icon is
system-reboot(and thus,system-reboot-symbolicfor symbolic). Before this, we were usingsystem-restart-symbolic, and had to provide an icon for this. This change increases compatibility with other icon themes, including Breeze, while retaining our own icon in case a theme does not provide it.Submitter Checklist
git rebase -i(if needed)