Skip to content

chore: use symbol-upload for dump-syms #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2024
Merged

chore: use symbol-upload for dump-syms #90

merged 2 commits into from
Apr 16, 2024

Conversation

bobbyg603
Copy link
Member

@bobbyg603 bobbyg603 commented Apr 14, 2024 •
edited
Loading

Description

Update to use symbol-upload's built-in dump-syms.

Fixes #87

TODO BG

  • Backend requests symbol for libunity.so/GUID/libunity.sym but we're uploading libunity/GUID/libunity.sym

Checklist

  • Tested manually
  • Unit tests pass with no errors or warnings
  • Documentation updated (if applicable)
  • Reviewed by at least 1 other contributor

@bobbyg603 bobbyg603 requested a review from daveplunkett April 14, 2024 04:09
@bobbyg603 bobbyg603 merged commit 7b7ca2b into main Apr 16, 2024
@bobbyg603 bobbyg603 deleted the dump-syms branch April 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveplunkett daveplunkett daveplunkett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Local Dump Syms
2 participants
@bobbyg603 @daveplunkett