Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1358 remove auto api #1369

Merged
merged 9 commits into from Jun 23, 2015
Merged

1358 remove auto api #1369

merged 9 commits into from Jun 23, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Jun 4, 2015

and vcs_legacy

should fix #1358
@dlonie @sankhesh please review

cdash is at:
https://open.cdash.org/buildSummary.php?buildid=3844786

@dlonie wonder why pep8 test is skipped

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 5, 2015

https://open.cdash.org/testDetails.php?test=341967758&build=3842977

Doesn't look like the pep8 executable is installing correctly.

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 5, 2015

Is the CDMS failure expected?

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 5, 2015

All tests pass for me, including CDMS_Test_multiple_formats, though this is failing on @doutriaux1's system and on the garant buildbot. The pep8 test seems to be failing due to a build/install issue on Charles' system that I can't reproduce.

We should figure out what's up with the CDMS test on the failing systems before merging. I'm not worried too much about pep8 getting fixed right now since it looks like an unrelated issue to this branch.

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 5, 2015

Is the CDMS thing related to #1368?

@jbeezley
Copy link

@jbeezley jbeezley commented Jun 5, 2015

The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.

This is the problem relying on external services in automated tests, though I'm not sure how we would go about mocking an opendap server.

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 5, 2015

Ah, my eye jumped to the exception output and I missed that. Ok, since the test is passing now, LGTM 👍

FWIW, I reran the script @jbeezley put on #1343, and there are still 10632 leaks from the vcs import, so this doesn't seem to have made much difference on that front.

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 5, 2015

Let's clean up those tests (remove the commented lines, or restore them and update the baselines) before merging, though.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 5, 2015

cdms2 is expected because of lab firewall. pep8 also isn't related to this PR. Probably mac related or something. Again probably should be looked at in another PR.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Jun 12, 2015

what's the final conclusion on this PR then?

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 12, 2015

@aashish24 let me uncomment the lines and generate a new baseline.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 12, 2015

ok only pep8 fails on mac, but it's because it seems to be looking for it in wrong path on mac, will open a dedicated issue for it. (#1386)

mac dashboard:
https://open.cdash.org/buildSummary.php?buildid=3856909

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 12, 2015

other projects depending on uvcdat are also falling apart because of the pyopenssl issue:



make[2]: *** [PYOPENSSL-prefix/src/PYOPENSSL-stamp/PYOPENSSL-install] Error 1
make[1]: *** [CMakeFiles/PYOPENSSL.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
-- Cython install command succeeded.  See also /export/gleckler1/PCMDI_METRICS/tmp/uvcdat/uvcdat_build/Cython-prefix/src/Cython-stamp/Cython-install-*.log

[ 69%] Completed 'Cython'
[ 69%] Built target Cython
-- FFMPEG build command succeeded.  See also /export/gleckler1/PCMDI_METRICS/tmp/uvcdat/uvcdat_build/FFMPEG-prefix/src/FFMPEG-stamp/FFMPEG-build-*.log

[ 69%] Performing install step for 'FFMPEG'
-- FFMPEG install command succeeded.  See also /export/gleckler1/PCMDI_METRICS/tmp/uvcdat/uvcdat_build/FFMPEG-prefix/src/FFMPEG-stamp/FFMPEG-install-*.log

[ 69%] Completed 'FFMPEG'
[ 69%] Built target FFMPEG
-- ESMF build command succeeded.  See also /export/gleckler1/PCMDI_METRICS/tmp/uvcdat/uvcdat_build/ESMF-prefix/src/ESMF-stamp/ESMF-build-*.log

[ 70%] Performing install step for 'ESMF'
-- ESMF install command succeeded.  See also /export/gleckler1/PCMDI_METRICS/tmp/uvcdat/uvcdat_build/ESMF-prefix/src/ESMF-stamp/ESMF-install-*.log

[ 70%] Completed 'ESMF'
[ 70%] Built target ESMF
make: *** [all] Error 2
 ERROR: Could not compile (make) cdat code
~/PCMDI_METRICS/tmp/uvcdat/uvcdat ~/PCMDI_METRICS/tmp/metrics

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 17, 2015

@chaosphere2112 @dlonie @aashish24 @jbeezley what's the hold on this?

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 18, 2015

@doutriaux1 The last comment regarding pyopenssl failing made me think there was still some work to do, or was that unrelated to this issue?

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 18, 2015

unrelated to this issue, it is actually fixed in #1388 that needs review (urgently because this very reason)

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 19, 2015

LGTM, but can't merge due to conflicts with master.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 22, 2015

darn! ok will rebase today.

doutriaux1 added 8 commits Jun 22, 2015
__slots__ now respected for Canvas objects
because __slots__ did not work before these went undetected
commenting out line for fillareaindices, this is completely broken now
and should be addressed as part of: #541
fix #1358
@doutriaux1 doutriaux1 force-pushed the 1358_remove_AutoAPI branch from e6ec043 to 5938c9f Jun 22, 2015
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 22, 2015

@dlonie @sankhesh rebased. Please review and approve.

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 23, 2015

Testing now.

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 23, 2015

LGTM

allisonvacanti pushed a commit that referenced this issue Jun 23, 2015
@allisonvacanti allisonvacanti merged commit 249ed79 into master Jun 23, 2015
4 checks passed
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Jun 23, 2015

yay 👏 😄

@doutriaux1 doutriaux1 deleted the 1358_remove_AutoAPI branch Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants