-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1358 remove auto api #1369
1358 remove auto api #1369
Conversation
https://open.cdash.org/testDetails.php?test=341967758&build=3842977 Doesn't look like the pep8 executable is installing correctly. |
Is the CDMS failure expected? |
All tests pass for me, including We should figure out what's up with the CDMS test on the failing systems before merging. I'm not worried too much about pep8 getting fixed right now since it looks like an unrelated issue to this branch. |
Is the CDMS thing related to #1368? |
This is the problem relying on external services in automated tests, though I'm not sure how we would go about mocking an opendap server. |
Let's clean up those tests (remove the commented lines, or restore them and update the baselines) before merging, though. |
cdms2 is expected because of lab firewall. pep8 also isn't related to this PR. Probably mac related or something. Again probably should be looked at in another PR. |
what's the final conclusion on this PR then? |
@aashish24 let me uncomment the lines and generate a new baseline. |
ok only pep8 fails on mac, but it's because it seems to be looking for it in wrong path on mac, will open a dedicated issue for it. (#1386) mac dashboard: |
other projects depending on uvcdat are also falling apart because of the pyopenssl issue:
|
@chaosphere2112 @dlonie @aashish24 @jbeezley what's the hold on this? |
@doutriaux1 The last comment regarding pyopenssl failing made me think there was still some work to do, or was that unrelated to this issue? |
unrelated to this issue, it is actually fixed in #1388 that needs review (urgently because this very reason) |
LGTM, but can't merge due to conflicts with master. |
darn! ok will rebase today. |
got vcs and cdms2
__slots__ now respected for Canvas objects
because __slots__ did not work before these went undetected
e6ec043
to
5938c9f
Compare
@dlonie @sankhesh rebased. Please review and approve. |
Testing now. |
LGTM |
yay 👏 😄 |
and vcs_legacy
should fix #1358
@dlonie @sankhesh please review
cdash is at:
https://open.cdash.org/buildSummary.php?buildid=3844786
@dlonie wonder why pep8 test is skipped