Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autotester (make it deterministic) by not using threads #178

Closed
adriweb opened this issue Feb 10, 2018 · 3 comments
Closed

Fix autotester (make it deterministic) by not using threads #178

adriweb opened this issue Feb 10, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@adriweb
Copy link
Member

adriweb commented Feb 10, 2018

@jacobly0 says it's possible and Runner is angry, so gl/hf :D

@adriweb
Copy link
Member Author

adriweb commented Feb 27, 2018

NTS: probably try to do what ez80sf does here: https://github.com/jacobly0/ez80sf/blob/0bd4a3307a280f81ce8ecd3544028b5fa60fb1a8/test/tester.c#L163
i.e. no emu_loop in another thread, instead just call cpu_execute in a loop manually, that we control.

From IRC:

<@jacobly> delay x milliseconds translates to execute 48000*x cycles
<@jacobly> therefore you get reproducible tests
<@Adriweb> actually yeah I guess we want to delay from the PoV of the calc, not the host
<@Adriweb> so the computer's performance doesn't really matter
<@Adriweb> and yeah, reproducible tests are the goal
<@jacobly> I mean there should be api for this
<@jacobly> which would also be useful for emscripten
<@Adriweb> indeed
<@jacobly> and my tester
<@jacobly> and linking

@adriweb adriweb changed the title Fix autotester by not using threads Fix autotester (make it deterministic) by not using threads Aug 28, 2018
@adriweb
Copy link
Member Author

adriweb commented Aug 28, 2018

Let's work on this sometime soon :)

@adriweb
Copy link
Member Author

adriweb commented Jan 16, 2019

This is getting ridiculous, let's really work on that soon :P
When it's done, we'll also be able to enable blocking CI on the toolchain (and here eventually), that'll make PR review easier and faster.

@adriweb adriweb added the BLOCKER Release-blocking issue label Jan 16, 2019
adriweb pushed a commit that referenced this issue Jan 17, 2019
adriweb pushed a commit that referenced this issue Jan 17, 2019
@adriweb adriweb modified the milestones: Any version, v1.3 May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants