Forward and back disasm view #529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
comment regarding the anonymous namespace in debugger.cpp: there does not appear to be a .cpp/h file that this fits into nicely. It can be pulled into its own header, kept inside debugger.cpp, or possibly refactored into cpu.c/h |
|
I'll let you rebase this since the first two commits are on master now anyway. The forward/back feature looks good, tested it and works fine 👍 As for the Step Over change, I guess I'll let others weigh in. |
Sightem
force-pushed
the
forward-and-back-disasm
branch
2 times, most recently
from
308dd06 to
69cc31e
Compare
Sightem
force-pushed
the
forward-and-back-disasm
branch
from
873f852 to
0bde2b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements browser style back/forward navigation in the disassembly view, accessible via Alt+Left/Alt+Right and mouse back/forward buttons.
Step Over has also been slightly improved to functions as a "Step Next" for non control flow instructions, providing a more intuitive experience