-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neutral density calculation example #387
Comments
I presume you don't mean this package -> https://pypi.org/project/pygamma/ right? |
This would be great! Linking the discussion from the Hive including installation issues and example code for NRI folks, is there some way we can get |
No, they can't add the package in the conda environment if it's not conda-installable... |
In that Hive post I linked @aidanheerdegen said "In some cases CMS have created a conda package in their channel." |
Sounds like good idea but unfortunately if it can't be installed via conda then we might need also in the example detailed installation instructions.
Let's ask them to do that then...! If there is need to do that then let's do it. I have this memory that there was another package by @geoffstanley? Was that conda-installable? Was it to do the same thing?... |
Read the Hive post. :) @geoffstanley recommends |
That's a more general discussion, not restricted to this issue here. But there is a new Centre of Excellence and we are discussing on how/whether the CMS infrastructure (eg the conda envs) would carry on in that Centre... |
OK -- sorry for posting prematurely :( |
@dsroberts - Is it better/easier/more feasible longer term to put this pip package in the CMS channel or conda-forge ? |
The sense I am getting is that |
@anton-seaice I think the best course of action long-term is get it on conda-forge. We don't know what is happening with the new centre, nor do we know what's happening with a lot of the the software we currently manage. My expectation is that the COECMS conda channel will not be maintained going forward. |
@adele-morrison I'm very keen for this chat but it does go beyond neutral surfaces! where do you get this sense???! Not from me I hope.. |
Why don't we open an issue in the pygamma package urging them to add it in conda-forge? |
Shall I open it? Could somebody point me to the GitHub repo of pygamma? |
Yeah, I am trying to find it. But I don't think there is one for the package that Geoff pointed to in the hive (https://currents.soest.hawaii.edu/hgstage/pygamma/) I found this other package: https://github.com/guidov/pygamman and this one https://github.com/geoffstanley/neutralocean I don't think Geoff's |
tagging @geoffstanley |
Are neutral surfaces the same as neutral densities? I.e., can we use a value of 28.3 to define AABW as per literature? |
Hello! Neutral Surfaces are 2D surfaces (depth as a function of latitude and longitude) while Neutral Density is a 3D scalar field (a density value in kg/m3 as a function of latitude, longitude, and depth). An isosurface of Neutral Density is a Neutral Surface. If you specifically need a 3D neutral density for global (or very large-scale) oceanography and you're ocean dataset has a similar climate to the Levitus climatology from the early 1980's, then currently McDougall and Jackett (1997)'s γⁿ is the one to use. Or, if you specifically need neutral density values for comparison with McDougall and Jackett (1997) values in published literature, then again their γⁿ is what you need. In that case, I believe Eric Firing's Maybe @efiring could upload Sometimes people think they need 3D neutral density, when in fact 2D neutral surfaces are needed. In this case, neutralocean provides much greater accuracy, isn't tied to the Levitus climatology, is fast, native-Python, and on conda-forge. The omega surfaces from Eventually, |
This issue has been mentioned on ACCESS Hive Community Forum. There might be relevant details there: https://forum.access-hive.org.au/t/post-clex-conda-analysis-environments-on-nci/2198/6 |
Thank you Geoff! That is a very clear explanation. In that case for the sake of this Documented Example, I will do the notebook with instructions on how to locally install |
That sounds great @julia-neme! |
This weekend @ocefpaf and I did a little updating of https://currents.soest.hawaii.edu/hgstage/pygamma to |
Thankyou @efiring :) |
BTW, the draft PR is passing: conda-forge/staged-recipes#26814 Just waiting on a stable release. |
Thanks to @ocefpaf, the pygamma wrapper of the original neutral density Fortran code by David Jackett is now available on conda-forge for MacOS and Linux. A Windows build likely will follow, but it's not working yet. The package is slightly renamed, with "_n" added to avoid conflict with the "pygamma" package on PyPI:
|
That's great! Thank you both very much. @anton-seaice @dsroberts , could we add the package to the current/next conda environments? |
@efiring thanks a lot! How did you hear about this issue -- I'm wondering! Also thanks for the clarification in respect to the |
@julia-neme yes, for sure. I'm on leave until the end of next week, I'll do this first thing when I'm back. |
@dsroberts is this included in the conda-env now? |
@navidcy it is now. Sorry, should have been more precise, my first day back from leave is today. |
no worries at all! |
I think people have started using
pygamma
to calculate neutral density surfaces. Would be great put an example notebook - with the caveat that I thinkpygamma
needs to be installed by the user as it does not come in the conda environments right? At least I think that was the case at the beginning of the year but I'm not up to date.The text was updated successfully, but these errors were encountered: