Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sea ice plots #294

Merged
merged 6 commits into from
Oct 15, 2023
Merged

Sea ice plots #294

merged 6 commits into from
Oct 15, 2023

Conversation

anton-seaice
Copy link
Collaborator

@anton-seaice anton-seaice commented Oct 2, 2023

Here is my suggestion for merging @julia-neme's plots and my artic plots for the sea-ice example.

Follows up from the conflict between #280 and #270

I took a slightly different approach to including two models, there is a constant at the top of the notebook which the user can change to select which model they are looking at.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anton-seaice
Copy link
Collaborator Author

@navidcy Do you mind reviewing this as you know the history :)

@navidcy
Copy link
Collaborator

navidcy commented Oct 14, 2023

Sure! I just hadnt had the time yet.

@navidcy
Copy link
Collaborator

navidcy commented Oct 14, 2023

Could you resolve the conflicts?

@navidcy navidcy removed the request for review from julia-neme October 14, 2023 16:48
@anton-seaice
Copy link
Collaborator Author

Could you resolve the conflicts?

Ok thats done :)

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I did some minor changes, mostly aesthetics. The only important one was to use .squeeze('time') instead of doing [0].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants