-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sea ice plots #294
Sea ice plots #294
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@navidcy Do you mind reviewing this as you know the history :) |
Sure! I just hadnt had the time yet. |
Could you resolve the conflicts? |
Ok thats done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I did some minor changes, mostly aesthetics. The only important one was to use .squeeze('time')
instead of doing [0]
.
Here is my suggestion for merging @julia-neme's plots and my artic plots for the sea-ice example.
Follows up from the conflict between #280 and #270
I took a slightly different approach to including two models, there is a constant at the top of the notebook which the user can change to select which model they are looking at.