Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake conversion Bathymetry #352

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Intake conversion Bathymetry #352

merged 3 commits into from
Jul 17, 2024

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 6, 2024

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anton-seaice
Copy link
Collaborator

anton-seaice commented Jul 3, 2024

This one is ready to review. I ran black on the notebook, so there are lots of formatting only changes.

@anton-seaice anton-seaice self-assigned this Jul 3, 2024
@anton-seaice anton-seaice requested a review from navidcy July 11, 2024 23:23
@anton-seaice
Copy link
Collaborator

@minghangli-uni Can you review this one ? :)

Copy link

LGTM! Thanks @anton-seaice

@anton-seaice anton-seaice merged commit 4fd5115 into main Jul 17, 2024
3 checks passed
@anton-seaice anton-seaice deleted the INTAKE_Bathymetry branch July 17, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants