-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit requirements for jupyter notebooks examples #340
Conversation
We can also add these requirements in the numpy
ortools >= 9.6
z3-solver[full, solvers]
python-sat[full, solvers]
... # whatever other solvers
jupyter[full, examples]
requests[full, examples]
pandas[full, examples]
... # whatever is needed for the examples to run Then a user can simply do |
If it is possible using the requirements file, it would be the best! It would simplify the life of the users and avoid the need to search all the commands to install all the packages separately |
The conclusion here was to not use the requirement file, since that would lead to many otherwise unneeded packages being installed (and we don't have time to figure out the optional requirements). So this should be good to merge now? |
Btw what we can also do is to install the packages from within the notebook. Actuallyt, any system-command can be executed using '!' before the command. |
I would not recommend putting the pip install within the notebook. As the user could want to define its own conda environment to test the notebook. It can be merge |
Added everything to the notebooks, and also cleaned up the assets used by all examples. This should be a little cleaner now. |
Add for all example notebooks the explicit list of Python packages the user should have (in addition to cpmpy) to make the notebooks run