Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.2 Developer Guide #109

Merged
merged 3 commits into from
Mar 20, 2019
Merged

V1.2 Developer Guide #109

merged 3 commits into from
Mar 20, 2019

Conversation

flxffy
Copy link

@flxffy flxffy commented Mar 20, 2019

Updated Developer guide such that it reflects the changes made thus far for the Ui component and the Warning Panel feature.

@JonathanLeeWH JonathanLeeWH added this to the v1.2 milestone Mar 20, 2019
@JonathanLeeWH JonathanLeeWH added type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new v1.2 For v1.2 project milestone labels Mar 20, 2019
@JonathanLeeWH JonathanLeeWH self-requested a review March 20, 2019 14:54
jtankw3
jtankw3 approved these changes Mar 20, 2019
View reviewed changes
Copy link

@jtankw3 jtankw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice description of the warning panel. Very detailed and clear.

JonathanLeeWH
JonathanLeeWH approved these changes Mar 20, 2019
View reviewed changes
Copy link

@JonathanLeeWH JonathanLeeWH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍 The UI class diagram is very nice and also the sequence diagram is detailed with regards to the implementation details.

@JonathanLeeWH JonathanLeeWH merged commit 7aa7180 into CS2103-AY1819S2-T12-3:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanLeeWH JonathanLeeWH JonathanLeeWH approved these changes

@jtankw3 jtankw3 jtankw3 approved these changes

Assignees
No one assigned
Labels
type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new v1.2 For v1.2 project milestone
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@flxffy @jtankw3 @JonathanLeeWH