Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DarkTheme CSS #134

Merged
merged 10 commits into from
Mar 29, 2019
Merged

Update DarkTheme CSS #134

merged 10 commits into from
Mar 29, 2019

Conversation

flxffy
Copy link

@flxffy flxffy commented Mar 29, 2019

For a more cohesive look to our product. Updated UG to include latest view of product

@flxffy flxffy added type.Enhancement An enhancement to an existing story v1.3 For v1.3 project milestone labels Mar 29, 2019
@flxffy flxffy added this to the v1.3 milestone Mar 29, 2019
@JonathanLeeWH
Copy link

There are still some checkstyle error:

Task :checkstyleMain
[ant:checkstyle] [ERROR] /home/travis/build/CS2103-AY1819S2-T12-3/main/src/main/java/seedu/address/ui/WarningPanel.java:41:99: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
[ant:checkstyle] [ERROR] /home/travis/build/CS2103-AY1819S2-T12-3/main/src/main/java/seedu/address/ui/WarningPanel.java:47:91: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]

I will update the branch as well for you.

JonathanLeeWH
JonathanLeeWH approved these changes Mar 29, 2019
View reviewed changes
Copy link

@JonathanLeeWH JonathanLeeWH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job in improving the dark theme for consistency and also the theme now looks more refined.

@flxffy flxffy merged commit 4fb3e14 into CS2103-AY1819S2-T12-3:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanLeeWH JonathanLeeWH JonathanLeeWH approved these changes

Assignees
No one assigned
Labels
type.Enhancement An enhancement to an existing story v1.3 For v1.3 project milestone
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@flxffy @JonathanLeeWH