Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.3 Model, Logic tests #139

Merged
merged 16 commits into from
Mar 31, 2019
Merged

V1.3 Model, Logic tests #139

merged 16 commits into from
Mar 31, 2019

Conversation

flxffy
Copy link

@flxffy flxffy commented Mar 31, 2019

Tests for WarningPanel and related predicates in Model and Logic components implemented.

@flxffy flxffy added the v1.3 For v1.3 project milestone label Mar 31, 2019
@flxffy flxffy added this to the v1.3 milestone Mar 31, 2019
@flxffy flxffy mentioned this pull request Mar 31, 2019
Closed
2 tasks
jtankw3
jtankw3 approved these changes Mar 31, 2019
View reviewed changes
Copy link

@jtankw3 jtankw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm not sure if we need a min quantity cause the user cannot enter negative numbers because of the validation.

@jtankw3 jtankw3 merged commit 7d9be43 into CS2103-AY1819S2-T12-3:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtankw3 jtankw3 jtankw3 approved these changes

Assignees
No one assigned
Labels
v1.3 For v1.3 project milestone
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flxffy @jtankw3