Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.4 Sorted medicine list #179

Merged
merged 11 commits into from
Apr 7, 2019
Merged

Conversation

flxffy
Copy link

@flxffy flxffy commented Apr 7, 2019

Feature is complete and working, some system tests are not working and they are almost impossible to debug/trace. Commented them out temporarily to seek help :(

EditCommandSystemTest line 254
EditCommandSystemTest#assertApplicationDisplaysExpected
DeleteCommandSystemTest line 65

@flxffy flxffy requested a review from jtankw3 April 7, 2019 13:11
Copy link

@jtankw3 jtankw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean code to sort all our lists. Looks like you had to change a lot of the test too! Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.4 For v1.4 project milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants