Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.4 Changed date and threshold validation #189

Merged
merged 6 commits into from
Apr 13, 2019

Conversation

flxffy
Copy link

@flxffy flxffy commented Apr 13, 2019

Changed expiry date and threshold validation to only accepts dates before 31/12/9999.
Made threshold for expiry flexible to change as the days go by so the threshold will always be number of days from (today to 31/12/9999) + 1

Copy link

@jtankw3 jtankw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JonathanLeeWH JonathanLeeWH merged commit 00b620e into CS2103-AY1819S2-T12-3:master Apr 13, 2019
@flxffy flxffy added the v1.4 For v1.4 project milestone label Apr 14, 2019
@flxffy flxffy added this to the v1.4 milestone Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.4 For v1.4 project milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants