Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer's Guide [20 Feb] #33

Merged
merged 10 commits into from
Feb 20, 2019
Merged

Developer's Guide [20 Feb] #33

merged 10 commits into from
Feb 20, 2019

Conversation

flxffy
Copy link

@flxffy flxffy commented Feb 20, 2019

Hello everyone,

I've updated the DevGuide as much as I could, following the week 4 documentations that we have already done. As for the other sections, I will only be able to update everything when we begin working on our features.

Copy link

@jtankw3 jtankw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But need to delete the trailing whitespaces for the travis check.

docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
@flxffy flxffy dismissed jtankw3’s stale review February 20, 2019 13:33

White spaces and reference link in Product Scope have been removed.

Copy link

@jtankw3 jtankw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Approved!

@JonathanLeeWH JonathanLeeWH merged commit fa8a344 into master Feb 20, 2019
@JonathanLeeWH JonathanLeeWH deleted the DevGuide branch February 20, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants