[mid v1.2] Populating warning panel with real values #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
March 8, 2019 14:56
JonathanLeeWH
approved these changes
Mar 11, 2019
jtankw3
reviewed
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populated warning panel with real values. Currently using default thresholds for filtration.
Changed
java.util.DateinExpirytojava.time.LocalDateas most of the the methods offered under theDateclass have been deprecated since JDK 1.1. In this case,LocalDatewill be more appropriate as the class is up to date. Furthermore, given the scope of this module, it will be safe to assume that the application will only be used locally (in Singapore).JUnit tests and relevant documentations for the current implementations will be completed by next week.