Skip to content

Conversation

MilyMilo
Copy link
Contributor

@MilyMilo MilyMilo commented Nov 21, 2023

  • extract challenge resolving code from each command to a reusable method
  • stop relying on config whenever it's not necessary (challenge new, format, lint)
  • improve variable naming (explicit challenge_instance instead of shadowing the challenge kwarg)
  • fix some typos

Closes #135

Miłosz Skaza added 2 commits November 21, 2023 14:47
- extract challenge resolving code from each command to a reusable method
- stop relying on config whenever it's not necessary (challenge new, format, lint)
@MilyMilo
Copy link
Contributor Author

MilyMilo commented Nov 29, 2023

I've made the challenge resolving methods static, so that they can be used outside of the challenge class (as utility functons).

I've also fixed 2 issues with plugins:

  1. It was not possible to add a custom command, because fire always received the vanilla CTFCLI class, instead of the one that can be modified with plugins
  2. __pycache__ inside the plugin directory would cause ctfcli to break

@ColdHeat ColdHeat merged commit 4e636f5 into CTFd:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't force repo initialization on all commands

2 participants