Skip to content

Support alternate Buildkit drivers #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

pl4nty
Copy link
Contributor

@pl4nty pl4nty commented Mar 7, 2024

Add --load to explicitly output Docker builds to local images, allowing drivers that don't have a default output type (ie everything except docker). Fixes #147

Is it worth adding some way to pass custom arguments too? --cache-from and --cache-to can significantly improve performance in CI scenarios.

supports alternative BuildKit drivers

Signed-off-by: Tom Plant <tom@tplant.com.au>
@ColdHeat
Copy link
Member

Pardon my ignorance here but I don't see what the point is of the --load switch? Do you want to have the image output as a tar file?

Additional arguments could be good but I think it would need to be generic. Perhaps something like --extra-args="--switch1=123"

@pl4nty
Copy link
Contributor Author

pl4nty commented Apr 16, 2024

--load loads the image into local storage. same as current behaviour, because the docker driver implicitly uses --load if no output is specified (for backwards compat). but other drivers require an explicit output argument, and will fail at the moment.

generic arguments sound great, I'm happy to send another PR if you'd like.

@ColdHeat
Copy link
Member

I think something could be done with extra build arguments I am just not sure about the interface to support (whether it's purely cli or if it should also be in the config file)

@ColdHeat ColdHeat merged commit 31ec803 into CTFd:master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Buildkit drivers for image builds
2 participants