Skip to content

Conversation

mmargenot
Copy link
Contributor

Please feel free to contact either Thomas or myself with any concerns you might have about our changes!

@mmargenot mmargenot changed the title The PyMC3 port is complete! Our PyMC3 port is complete! Sep 27, 2016
@mmargenot
Copy link
Contributor Author

There were some changes made to PyMC3 related to positional arguments so I went through and corrected the examples that would have been affected.

@CamDavidsonPilon
Copy link
Owner

Thanks for the general cleanup of some of my old code too! 👌
Overall, changes look good. I'm going to pull it locally and play around with PyMC3 too

@CamDavidsonPilon
Copy link
Owner

  1. In the added header, you have my name as Cam Pilon, can you update it to Cam Davidson-Pilon?
  2. In place of commented-out code, I think we should just delete it entirely. No value in keep it around.
  3. The matplotlib styles are not the the same, but I can go through later and fix this (it happens often when another contributor wants to add content, but has rerun the plotting code).

@mmargenot
Copy link
Contributor Author

Is there anywhere in particular that has commented-out code in an obtrusive place? I'm going through the individual scripts as they seem to have some.

What is the style that you are using? I can make a note to use it every time I re-run plots.

@CamDavidsonPilon
Copy link
Owner

It's the .py scripts mostly. A couple ways to update the style:

  1. (brute force) replacing the matplotlibrc file on your comp with https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/blob/master/styles/matplotlibrc
  2. using the code: ply.styles.use('bmh') before plotting anything (and I guess deleting the cell)
  3. Ignore it 💃

@mmargenot
Copy link
Contributor Author

I think I may ignore it for now.
💃 💃 💃

@mmargenot
Copy link
Contributor Author

Plot style should be good for each chapter now.

@CamDavidsonPilon
Copy link
Owner

👍 happy with this. Merging!

@CamDavidsonPilon CamDavidsonPilon merged commit 42b5680 into CamDavidsonPilon:master Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants