-
Notifications
You must be signed in to change notification settings - Fork 50
Add simple example Jupyter notebook (for Binder) #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple example Jupyter notebook (for Binder) #127
Conversation
b05926b
to
69510ff
Compare
Just as a note: this looks good so far. I'll do another review and approve when the |
efdf8b5
to
608f224
Compare
Removed TODO about path stuff (I won't be able to investigate anytime soon). Briefly trying the JupyterLab setup, but may descope that as well. |
JupyterLab does not work easily; will leave in TODO; breadcrumb commit: 608f224 I think the remaining TODOs can remain as they are. @tao558 Might you have time to take a look? |
@EricCousineau-TRI I'll take a look ASAP |
FYI I changed requirements away from use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one comment looks good. Are you OK with me squashing the commits when merging?
Yup! |
Please squash-merge if that's an option. If not, I can squash myself since review is done. |
Thanks @EricCousineau-TRI! Good to finally get this merged. |
Towards #126
Preview Link:
https://mybinder.org/v2/gh/EricCousineau-TRI/pygccxml/feature-py-notebook-example?filepath=pygccxml/docs/examples/notebook/example.ipynb