This repository has been archived by the owner. It is now read-only.
Extract shared methods to expose common structure #13
Conversation
Smarker
approved these changes
Aug 7, 2017
LGTM
erikschlegel
approved these changes
Aug 9, 2017
LGTM
| @@ -145,7 +158,7 @@ export const Dashboard = React.createClass({ | |||
| <div key={'locations'} className="doughnutChart"> | |||
| <GraphCard cardHeader={cardHeader}> | |||
| <PopularLocationsChart | |||
| mainEdge={this.state.categoryValue["name_"+this.state.language]} | |||
| mainEdge={this.getMainEdge()} | |||
I think you're going to run into translation issues here?
The method this delegates to already takes care of localization :)
getMainEdge() {
if (!this.state.categoryValue) {
return undefined;
}
return this.state.categoryValue[`name_${this.state.language}`] || this.state.categoryValue.name;
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Not sure why we had three different ways of getting the mainEdge before. Would this refactor make sense?
The text was updated successfully, but these errors were encountered: