This repository has been archived by the owner. It is now read-only.
Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesExtract shared methods to expose common structure #13
Conversation
c-w
requested a review
from erikschlegel
Jul 31, 2017
c-w
added some commits
Jul 31, 2017
c-w
force-pushed the
dashboard-extract-shared
branch
from
63641ce
to
081c8a5
Aug 9, 2017
| @@ -145,7 +158,7 @@ export const Dashboard = React.createClass({ | |||
| <div key={'locations'} className="doughnutChart"> | |||
| <GraphCard cardHeader={cardHeader}> | |||
| <PopularLocationsChart | |||
| mainEdge={this.state.categoryValue["name_"+this.state.language]} | |||
| mainEdge={this.getMainEdge()} | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c-w
Aug 9, 2017
Author
Member
The method this delegates to already takes care of localization :)
getMainEdge() {
if (!this.state.categoryValue) {
return undefined;
}
return this.state.categoryValue[`name_${this.state.language}`] || this.state.categoryValue.name;
}
c-w
merged commit 71f8dc9
into
master
Aug 9, 2017
c-w
deleted the
dashboard-extract-shared
branch
Aug 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
c-w commentedJul 31, 2017
Not sure why we had three different ways of getting the mainEdge before. Would this refactor make sense?