Skip to content

Commit 05668e1

Browse files
authored
Merge pull request #246 from bp-cos/feature/pr_template
feat(eng-1234): Added a pull request template and updated the readme
2 parents eedea3b + 019f419 commit 05668e1

File tree

2 files changed

+62
-34
lines changed

2 files changed

+62
-34
lines changed

.github/pull_request_template.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
<!--
2+
Before you submit your Pull Request, make sure you picked the correct branch:
3+
- For hotfixes, select "master" as the target branch
4+
- For new features and non-hotfix bugfixes, select "develop" as the target branch
5+
- For release feature fixes, select the relevant release branch (release/X.Y.Z) as the target branch
6+
7+
Ticketd PRs should be prefixed with the ticket id, e.g. `feat(ENG-123): some really great stuff`
8+
-->
9+
10+
- Ticket: []
11+
- Feature flag: n/a
12+
13+
## Purpose
14+
15+
<!-- Describe the purpose of your changes. -->
16+
17+
## Summary of Changes
18+
19+
<!-- Briefly describe or list your changes. -->
20+
21+
## Screenshot(s)
22+
23+
<!-- Attach screenshots if applicable. -->
24+
25+
## Side Effects
26+
27+
<!-- Any possible side effects? (https://en.wikipedia.org/wiki/Side_effect_%28computer_science%29) -->
28+
29+
## QA Notes
30+
31+
<!--
32+
Does this change need QA? If so, this section is required.
33+
- What pages should be tested?
34+
- Is cross-browser testing required/recommended?
35+
- What edge cases should QA be aware of?
36+
- What level of risk would you expect these changes to have?
37+
- For each feature flag (if any), what is the expected behavior with the flag enabled vs disabled?
38+
-->

README.md

Lines changed: 24 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,33 @@
1-
# OSF
1+
# Open Science Framework Angular Project
22

3-
This project was generated using [Angular CLI](https://github.com/angular/angular-cli) version 19.2.0.
3+
This is the front-end angular repository for the Open Science Framework (OSF).
44

5-
## Development server
5+
## Running the project
66

7-
To start a local development server, run:
7+
1. npm install
8+
2. npm run start
9+
3. browse to localhost:4200
810

9-
```bash
10-
ng serve
11-
```
11+
## Testing the project
1212

13-
Once the server is running, open your browser and navigate to `http://localhost:4200/`. The application will automatically reload whenever you modify any of the source files.
13+
The project uses jest for unit testing.
14+
A "counter" script executes before and after each test run to track how many times the unit
15+
tests are run locally. The output is displayed.
1416

15-
## Code scaffolding
17+
1. npm run test (single test run)
18+
2. npm run test:watch (single run after file save)
19+
3. npm run test:coverage (code coverage results)
20+
- all commits must pass the local pipeline for test coverage
21+
4. npm run test:check-coverage-thresholds
22+
- Verifies newly added tests match the thresholds
23+
- This is only used until we hit 100% test coverage
24+
- all commits must pass the local pipeline for test coverage
1625

17-
Angular CLI includes powerful code scaffolding tools. To generate a new component, run:
26+
## Github pipeline
1827

19-
```bash
20-
ng generate component component-name
21-
```
28+
The `.github` folder contains the following:
2229

23-
For a complete list of available schematics (such as `components`, `directives`, or `pipes`), run:
24-
25-
```bash
26-
ng generate --help
27-
```
28-
29-
## Building
30-
31-
To build the project run:
32-
33-
```bash
34-
ng build
35-
```
36-
37-
This will compile your project and store the build artifacts in the `dist/` directory. By default, the production build optimizes your application for performance and speed.
38-
39-
Angular CLI does not come with an end-to-end testing framework by default. You can choose one that suits your needs.
40-
41-
## Additional Resources
42-
43-
For more information on using the Angular CLI, including detailed command references, visit the [Angular CLI Overview and Command Reference](https://angular.dev/tools/cli) page.
30+
1. The test run "counter" scripts
31+
2. The "counter" file
32+
3. The github action work flow scripts
33+
4. The github PR templates

0 commit comments

Comments
 (0)