fix(bugs): fixed bugs

nsemets · nsemets · commit b9435bf7c0cc · 2025-07-15T14:31:45.000+03:00
diff --git a/src/app/core/constants/nav-items.constant.ts b/src/app/core/constants/nav-items.constant.ts
@@ -60,6 +60,11 @@ export const MENU_ITEMS: MenuItem[] = [
         label: 'navigation.preprintsSubRoutes.myPreprints',
         routerLinkActiveOptions: { exact: false },
       },
+      {
+        routerLink: '/preprints/my-reviewing',
+        label: 'navigation.preprintsSubRoutes.myReviewing',
+        routerLinkActiveOptions: { exact: true },
+      },
     ],
   },
   {
diff --git a/src/app/features/moderation/collection-moderation.routes.ts b/src/app/features/moderation/collection-moderation.routes.ts
@@ -26,13 +26,13 @@ export const collectionModerationRoutes: Routes = [
           import('./components/collection-moderation-submissions/collection-moderation-submissions.component').then(
             (m) => m.CollectionModerationSubmissionsComponent
           ),
-        data: { tab: CollectionModerationTab.AllItems, skipBreadcrumbs: true },
+        data: { tab: CollectionModerationTab.AllItems },
       },
       {
         path: 'moderators',
         loadComponent: () =>
           import('./components/moderators-list/moderators-list.component').then((m) => m.ModeratorsListComponent),
-        data: { resourceType: ResourceType.Collection, tab: CollectionModerationTab.Moderators, skipBreadcrumbs: true },
+        data: { resourceType: ResourceType.Collection, tab: CollectionModerationTab.Moderators },
         providers: [provideStates([ModeratorsState])],
       },
       {
@@ -41,7 +41,7 @@ export const collectionModerationRoutes: Routes = [
           import('./components/notification-settings/notification-settings.component').then(
             (m) => m.NotificationSettingsComponent
           ),
-        data: { tab: CollectionModerationTab.Settings, skipBreadcrumbs: true },
+        data: { tab: CollectionModerationTab.Settings },
       },
     ],
   },
diff --git a/src/app/features/moderation/pages/my-preprint-reviewing/my-preprint-reviewing.component.html b/src/app/features/moderation/pages/my-preprint-reviewing/my-preprint-reviewing.component.html
@@ -16,7 +16,7 @@ <h2>{{ 'project.overview.recentActivity.title' | translate }}</h2>
     </p-card>
 
     <p-card class="col-12 xl:col-5">
-      <h2>{{ 'navigation.preprintsSubRoutes.myReviewing' | translate }}</h2>
+      <h2>{{ 'preprints.providers' | translate }}</h2>
 
       <div class="flex flex-column gap-4 mt-4">
         @if (isPreprintProvidersLoading()) {
diff --git a/src/app/features/moderation/preprint-moderation.routes.ts b/src/app/features/moderation/preprint-moderation.routes.ts
@@ -26,21 +26,21 @@ export const preprintModerationRoutes: Routes = [
           import('./components/registry-submissions/registry-submissions.component').then(
             (m) => m.RegistrySubmissionsComponent
           ),
-        data: { tab: PreprintModerationTab.Submissions, skipBreadcrumbs: true },
+        data: { tab: PreprintModerationTab.Submissions },
       },
       {
         path: 'withdrawals',
         loadComponent: () =>
           import('./components/collection-moderation-submissions/collection-moderation-submissions.component').then(
             (m) => m.CollectionModerationSubmissionsComponent
           ),
-        data: { tab: PreprintModerationTab.WithdrawalRequests, skipBreadcrumbs: true },
+        data: { tab: PreprintModerationTab.WithdrawalRequests },
       },
       {
         path: 'moderators',
         loadComponent: () =>
           import('./components/moderators-list/moderators-list.component').then((m) => m.ModeratorsListComponent),
-        data: { resourceType: ResourceType.Preprint, tab: PreprintModerationTab.Moderators, skipBreadcrumbs: true },
+        data: { resourceType: ResourceType.Preprint, tab: PreprintModerationTab.Moderators },
         providers: [provideStates([ModeratorsState])],
       },
       {
@@ -49,15 +49,15 @@ export const preprintModerationRoutes: Routes = [
           import('./components/notification-settings/notification-settings.component').then(
             (m) => m.NotificationSettingsComponent
           ),
-        data: { tab: PreprintModerationTab.Notifications, skipBreadcrumbs: true },
+        data: { tab: PreprintModerationTab.Notifications },
       },
       {
         path: 'settings',
         loadComponent: () =>
           import('./components/preprint-moderation-settings/preprint-moderation-settings.component').then(
             (m) => m.PreprintModerationSettingsComponent
           ),
-        data: { tab: PreprintModerationTab.Settings, skipBreadcrumbs: true },
+        data: { tab: PreprintModerationTab.Settings },
       },
     ],
   },
diff --git a/src/app/features/moderation/registry-moderation.routes.ts b/src/app/features/moderation/registry-moderation.routes.ts
@@ -26,28 +26,28 @@ export const registryModerationRoutes: Routes = [
           import('./components/registry-submissions/registry-submissions.component').then(
             (m) => m.RegistrySubmissionsComponent
           ),
-        data: { tab: RegistryModerationTab.Submitted, skipBreadcrumbs: true },
+        data: { tab: RegistryModerationTab.Submitted },
       },
       {
         path: 'pending',
         loadComponent: () =>
           import('./components/collection-moderation-submissions/collection-moderation-submissions.component').then(
             (m) => m.CollectionModerationSubmissionsComponent
           ),
-        data: { tab: RegistryModerationTab.Pending, skipBreadcrumbs: true },
+        data: { tab: RegistryModerationTab.Pending },
       },
       {
         path: 'moderators',
         loadComponent: () =>
           import('./components/moderators-list/moderators-list.component').then((m) => m.ModeratorsListComponent),
-        data: { resourceType: ResourceType.Registration, tab: RegistryModerationTab.Moderators, skipBreadcrumbs: true },
+        data: { resourceType: ResourceType.Registration, tab: RegistryModerationTab.Moderators },
         providers: [provideStates([ModeratorsState])],
       },
       {
         path: 'settings',
         loadComponent: () =>
           import('./components/registry-settings/registry-settings.component').then((m) => m.RegistrySettingsComponent),
-        data: { tab: RegistryModerationTab.Settings, skipBreadcrumbs: true },
+        data: { tab: RegistryModerationTab.Settings },
       },
     ],
   },
diff --git a/src/app/features/preprints/pages/select-preprint-service/select-preprint-service.component.html b/src/app/features/preprints/pages/select-preprint-service/select-preprint-service.component.html
@@ -6,9 +6,9 @@ <h2>{{ 'preprints.selectService.sectionTitle' | translate }}</h2>
     <span>
       {{ 'preprints.selectService.description' | translate }}
     </span>
-    <a href="https://help.osf.io/article/376-preprints-home-page">{{
-      'preprints.selectService.learnMore' | translate
-    }}</a>
+    <a href="https://help.osf.io/article/376-preprints-home-page">
+      {{ 'preprints.selectService.learnMore' | translate }}
+    </a>
   </p>
   <section class="m-t-48 grid justify-content-center align-items-start gap-4">
     @if (areProvidersLoading()) {
diff --git a/src/app/features/preprints/preprints.routes.ts b/src/app/features/preprints/preprints.routes.ts
@@ -93,7 +93,6 @@ export const preprintsRoutes: Routes = [
           import('@osf/features/moderation/pages/my-preprint-reviewing/my-preprint-reviewing.component').then(
             (m) => m.MyPreprintReviewingComponent
           ),
-        data: { skipBreadcrumbs: true },
         providers: [provideStates([PreprintModerationState])],
       },
     ],
diff --git a/src/app/features/project/metadata/project-metadata.component.html b/src/app/features/project/metadata/project-metadata.component.html
@@ -24,89 +24,83 @@
         @for (tab of tabs(); track $index) {
           <p-tabpanel [value]="tab.id">
             @if (tab.type === 'project') {
-              @if (currentProjectLoading()) {
-                <div class="flex-1 mt-4 md:mt-8 lg:pt-5">
-                  <osf-loading-spinner />
-                </div>
-              } @else {
-                <div class="flex-column flex flex-1 w-full bg-white lg:flex-row">
-                  <div class="col-12 lg:col-6 flex flex-column gap-4">
-                    <p-card>
-                      <div class="flex justify-content-between flex-wrap gap-4">
-                        <div class="flex flex-column gap-2 flex-1">
-                          <h2>
-                            {{ 'project.overview.metadata.dateCreated' | translate }}
-                          </h2>
-
-                          <p class="m-0 text-color-secondary">
-                            {{ currentProject()?.dateCreated | date: 'MMM d, y, h:mm a' }}
-                          </p>
-                        </div>
-
-                        <div class="flex flex-column gap-2 flex-1">
-                          <h2>
-                            {{ 'project.overview.metadata.dateUpdated' | translate }}
-                          </h2>
-
-                          <p class="m-0 text-color-secondary">
-                            {{ currentProject()?.dateModified | date: 'MMM d, y, h:mm a' }}
-                          </p>
-                        </div>
+              <div class="flex-column flex flex-1 w-full bg-white lg:flex-row">
+                <div class="col-12 lg:col-6 flex flex-column gap-4">
+                  <p-card>
+                    <div class="flex justify-content-between flex-wrap gap-4">
+                      <div class="flex flex-column gap-2 flex-1">
+                        <h2>
+                          {{ 'project.overview.metadata.dateCreated' | translate }}
+                        </h2>
+
+                        <p class="m-0 text-color-secondary">
+                          {{ currentProject()?.dateCreated | date: 'MMM d, y, h:mm a' }}
+                        </p>
                       </div>
-                    </p-card>
-
-                    <osf-project-metadata-contributors
-                      (openEditContributorDialog)="openEditContributorDialog()"
-                      [currentProject]="currentProject()"
-                    />
-
-                    <osf-project-metadata-description
-                      (openEditDescriptionDialog)="openEditDescriptionDialog()"
-                      [currentProject]="currentProject()"
-                    />
-
-                    <osf-project-metadata-resource-information
-                      (openEditResourceInformationDialog)="openEditResourceInformationDialog()"
-                      [customItemMetadata]="customItemMetadata()"
-                    />
-
-                    <osf-project-metadata-funding
-                      (openEditFundingDialog)="openEditFundingDialog()"
-                      [currentProject]="currentProject()"
-                    />
-
-                    <osf-project-metadata-affiliated-institutions
-                      (openEditAffiliatedInstitutionsDialog)="openEditAffiliatedInstitutionsDialog()"
-                      [currentProject]="currentProject()"
-                    />
-                  </div>
 
-                  <div class="col-12 lg:col-6 flex flex-column gap-4">
-                    <osf-project-metadata-license
-                      (openEditLicenseDialog)="openEditLicenseDialog()"
-                      [currentProject]="currentProject()"
-                    />
-
-                    <osf-project-metadata-publication-doi
-                      (openEditPublicationDoiDialog)="handleEditDoi()"
-                      [currentProject]="currentProject()"
-                    />
-
-                    <p-card>
-                      <div class="flex flex-column gap-3">
-                        <h2>{{ 'project.overview.metadata.tags' | translate }}</h2>
-
-                        <osf-tags-input
-                          (tagsChanged)="onTagsChanged($event)"
-                          [tags]="currentProject()?.tags || []"
-                        ></osf-tags-input>
+                      <div class="flex flex-column gap-2 flex-1">
+                        <h2>
+                          {{ 'project.overview.metadata.dateUpdated' | translate }}
+                        </h2>
+
+                        <p class="m-0 text-color-secondary">
+                          {{ currentProject()?.dateModified | date: 'MMM d, y, h:mm a' }}
+                        </p>
                       </div>
-                    </p-card>
+                    </div>
+                  </p-card>
 
-                    <osf-project-metadata-subjects [projectId]="currentProject()?.id" />
-                  </div>
+                  <osf-project-metadata-contributors
+                    (openEditContributorDialog)="openEditContributorDialog()"
+                    [currentProject]="currentProject()"
+                  />
+
+                  <osf-project-metadata-description
+                    (openEditDescriptionDialog)="openEditDescriptionDialog()"
+                    [currentProject]="currentProject()"
+                  />
+
+                  <osf-project-metadata-resource-information
+                    (openEditResourceInformationDialog)="openEditResourceInformationDialog()"
+                    [customItemMetadata]="customItemMetadata()"
+                  />
+
+                  <osf-project-metadata-funding
+                    (openEditFundingDialog)="openEditFundingDialog()"
+                    [currentProject]="currentProject()"
+                  />
+
+                  <osf-project-metadata-affiliated-institutions
+                    (openEditAffiliatedInstitutionsDialog)="openEditAffiliatedInstitutionsDialog()"
+                    [currentProject]="currentProject()"
+                  />
                 </div>
-              }
+
+                <div class="col-12 lg:col-6 flex flex-column gap-4">
+                  <osf-project-metadata-license
+                    (openEditLicenseDialog)="openEditLicenseDialog()"
+                    [currentProject]="currentProject()"
+                  />
+
+                  <osf-project-metadata-publication-doi
+                    (openEditPublicationDoiDialog)="handleEditDoi()"
+                    [currentProject]="currentProject()"
+                  />
+
+                  <p-card>
+                    <div class="flex flex-column gap-3">
+                      <h2>{{ 'project.overview.metadata.tags' | translate }}</h2>
+
+                      <osf-tags-input
+                        (tagsChanged)="onTagsChanged($event)"
+                        [tags]="currentProject()?.tags || []"
+                      ></osf-tags-input>
+                    </div>
+                  </p-card>
+
+                  <osf-project-metadata-subjects [projectId]="currentProject()?.id" />
+                </div>
+              </div>
             } @else {
               <div class="p-6">
                 @if (selectedCedarTemplate() && selectedCedarRecord()) {
diff --git a/src/app/features/project/metadata/project-metadata.component.ts b/src/app/features/project/metadata/project-metadata.component.ts
@@ -55,7 +55,7 @@ import {
 import { ResourceType } from '@osf/shared/enums';
 import { ContributorsSelectors, GetAllContributors } from '@osf/shared/stores';
 import { LoadingSpinnerComponent, SubHeaderComponent, TagsInputComponent } from '@shared/components';
-import { CustomConfirmationService, ToastService } from '@shared/services';
+import { CustomConfirmationService, LoaderService, ToastService } from '@shared/services';
 
 @Component({
   selector: 'osf-project-metadata',
@@ -93,6 +93,7 @@ export class ProjectMetadataComponent implements OnInit {
   private readonly dialogService = inject(DialogService);
   private readonly translateService = inject(TranslateService);
   private readonly toastService = inject(ToastService);
+  private readonly loaderService = inject(LoaderService);
   private readonly customConfirmationService = inject(CustomConfirmationService);
 
   tabs = signal<{ id: string; label: string; type: 'project' | 'cedar' }[]>([]);
diff --git a/src/app/features/registries/components/review/review.component.html b/src/app/features/registries/components/review/review.component.html
@@ -1,4 +1,4 @@
-<section class="flex flex-column flex-1 p-5 gap-4 w-full">
+<section class="flex flex-column flex-1 bg-white p-5 gap-4 w-full">
   <p-card>
     <h2 class="mb-4">{{ 'navigation.registration.metadata' | translate }}</h2>
 
diff --git a/src/app/features/registries/pages/my-registrations/my-registrations.component.html b/src/app/features/registries/pages/my-registrations/my-registrations.component.html
@@ -27,7 +27,7 @@
             [(selectedValue)]="selectedTab"
           ></osf-select>
         }
-        <!--Drafts-->
+
         <p-tabpanel [value]="RegistrationTab.Drafts" class="flex flex-column gap-4 flex-1">
           @if (isDraftRegistrationsLoading()) {
             @for (item of skeletons; track $index) {
@@ -50,7 +50,6 @@
           }
         </p-tabpanel>
 
-        <!--Submitted-->
         <p-tabpanel [value]="RegistrationTab.Submitted" class="flex flex-column gap-4 flex-1">
           @if (isSubmittedRegistrationsLoading()) {
             @for (item of skeletons; track $index) {
@@ -60,7 +59,7 @@
             @if (submittedRegistrationsTotalCount() === 0) {
               <ng-container *ngTemplateOutlet="noRegistration"></ng-container>
             }
-            @for (registration of submittedRegistrations(); track registration.registry) {
+            @for (registration of submittedRegistrations(); track $index) {
               <osf-registration-card [registrationData]="registration" />
             }
             @if (submittedRegistrationsTotalCount() > itemsPerPage) {
diff --git a/src/app/shared/components/stepper/stepper.component.html b/src/app/shared/components/stepper/stepper.component.html
@@ -1,6 +1,6 @@
 <div class="stepper-container">
   <div class="stepper-circles-lines-row">
-    @for (step of steps(); track step.value; let i = $index) {
+    @for (step of steps(); track $index; let i = $index) {
       @if (currentStep()) {
         <button
           class="step-circle"
@@ -26,7 +26,7 @@
     }
   </div>
   <div class="stepper-labels-row">
-    @for (step of steps(); track step.value) {
+    @for (step of steps(); track $index) {
       <div class="step-label">{{ step.label | translate }}</div>
     }
   </div>
diff --git a/src/app/shared/components/tags-input/tags-input.component.html b/src/app/shared/components/tags-input/tags-input.component.html
@@ -7,4 +7,5 @@
     separator=","
     [required]="required()"
   ></p-chips>
+  <small>{{ 'common.hint.tagSeparators' | translate }}</small>
 </div>
diff --git a/src/assets/i18n/en.json b/src/assets/i18n/en.json
@@ -106,6 +106,9 @@
     },
     "placeholder": {
       "addTag": "Add tags"
+    },
+    "hint": {
+      "tagSeparators": "Use enter or comma to create a tag."
     }
   },
   "navigation": {
@@ -1842,7 +1845,8 @@
           }
         }
       }
-    }
+    },
+    "providers": "Providers"
   },
   "registries": {
     "title": "Registries",

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<section class="flex flex-column flex-1 p-5 gap-4 w-full">`
	`1`	`+<section class="flex flex-column flex-1 bg-white p-5 gap-4 w-full">`
`2`	`2`	`<p-card>`
`3`	`3`	`<h2 class="mb-4">{{ 'navigation.registration.metadata' \| translate }}</h2>`
`4`	`4`