Skip to content

Use proper URLs for import statements #12911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

Use proper URLs for import statements #12911

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aab565
Use proper URLs for import statements
javagl Sep 23, 2025
2fcefac
make sure imports are strings
jjspace Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { readFile, writeFile } from "node:fs/promises";
import { EOL } from "node:os";
import path from "node:path";
import { finished } from "node:stream/promises";
import { fileURLToPath } from "node:url";
import { fileURLToPath, pathToFileURL } from "node:url";

import esbuild from "esbuild";
import { globby } from "globby";
Expand Down Expand Up @@ -664,7 +664,7 @@ const externalResolvePlugin = {
export async function getSandcastleConfig() {
const configPath = "packages/sandcastle/sandcastle.config.js";
const configImportPath = path.join(projectRoot, configPath);
const config = await import(configImportPath);
const config = await import(pathToFileURL(configImportPath).href);
const options = config.default;
return {
...options,
Expand Down Expand Up @@ -698,7 +698,9 @@ export async function buildSandcastleGallery(includeDevelopment) {
__dirname,
"../packages/sandcastle/scripts/buildGallery.js",
);
const { buildGalleryList } = await import(buildGalleryScriptPath);
const { buildGalleryList } = await import(
pathToFileURL(buildGalleryScriptPath).href
);

await buildGalleryList({
rootDirectory,
Expand Down
Loading