Use proper URLs for import statements #12911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @javagl! ✅ We can confirm we have a CLA on file for you. |
This was referenced Sep 23, 2025
jjspace
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
I really hate the way windows treats paths, and subsequently the hoops node seems to jump through to accommodate windows paths.
Thanks for the change @javagl. I made one small change to ensure the paths imported are always strings. It does try to coerce the value but good to be explicit.
|
Yup, definitely! I was already in the process of doing just that, PR shortly. Edit: #12912 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to become a fix for #12910 , but to avoid merge conflicts given the larger restructuring that seems to be in progress at #12904, this is now a PR into that state.
This only changes two
importcalls to make sure that they don't receive a path, but an actual url.Ping @jjspace