Skip to content

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Sep 23, 2025

Description

This is a "duplicate" pr to bring the change from #12911 into main for anyone developing on Windows.

Issue number and link

Fixes #12910

Testing plan

  • Make sure npm run build doesn't fail

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor Author

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved these changes in #12911 this PR just ports to main, I'm comfortable just merging this

@jjspace jjspace merged commit b04b592 into main Sep 23, 2025
10 checks passed
@jjspace jjspace deleted the import-paths-windows branch September 23, 2025 20:31
@jjspace jjspace mentioned this pull request Sep 26, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on Windows for 1.133.1
1 participant