Add secretValue to CxSecretsResult and update related tests (#881)

Author: cx-ben-alvo

src/main/secrets/CxSecrets.ts

@@ -3,6 +3,7 @@ import {CxRealtimeEngineStatus} from "../oss/CxRealtimeEngineStatus";
 export default class CxSecretsResult {
     title: string;
     description: string;
+    secretValue: string;
     filepath: string;
     severity: CxRealtimeEngineStatus;
     locations: { line: number, startIndex: number, endIndex: number }[];
@@ -14,6 +15,7 @@ export default class CxSecretsResult {
                 const secretsResult = new CxSecretsResult();
                 secretsResult.title = member.Title;
                 secretsResult.description = member.Description;
+                secretsResult.secretValue = member.SecretValue;
                 secretsResult.filepath = member.FilePath;
                 secretsResult.severity = member.Severity as CxRealtimeEngineStatus;
                 secretsResult.locations = Array.isArray(member.Locations)

src/tests/ScanTest.test.ts

@@ -183,7 +183,7 @@ describe("ScanCreate cases", () => {
         expect(cxCommandOutput.exitCode).toBe(0);
     });
 
-    it.skip('ScanOss with ignored package should filter results', async () => {
+    it('ScanOss with ignored package should filter results', async () => {
     const wrapper = new CxWrapper(cxScanConfig);
     const sourceFile = "tsc/tests/data/package.json";
     const ignoredFile = "tsc/tests/data/checkmarxIgnoredTempFile.json";
@@ -213,7 +213,7 @@ describe("ScanCreate cases", () => {
         expect(cxCommandOutput.exitCode).toBe(0);
     });
 
-    it.skip('ScanSecrets with ignore file filters the result', async () => {
+    it('ScanSecrets with ignore file filters the result', async () => {
     const wrapper = new CxWrapper(cxScanConfig);
     const cxCommandOutput: CxCommandOutput = await wrapper.secretsScanResults(
         "src/tests/data/secret-exposed.txt",
@@ -223,7 +223,7 @@ describe("ScanCreate cases", () => {
     console.log("Json object from scanSecrets with ignore file: " + JSON.stringify(cxCommandOutput));
     expect(cxCommandOutput.payload).toBeDefined();
     expect(Array.isArray(cxCommandOutput.payload)).toBe(true);
-    expect(cxCommandOutput.payload.length).toBe(0);
+    expect(cxCommandOutput.payload.pop().length).toBe(0);
     expect(cxCommandOutput.exitCode).toBe(0);
 });
 

src/tests/data/ignoreFileSecrets.json

@@ -1,7 +1,7 @@
 [
 {
     "Title": "github-pat",
-    "FilePath": "/Users/itaypaz/Library/CloudStorage/OneDrive-Checkmarx/Documents/jswrapper/ast-cli-javascript-wrapper/src/tests/data/secret-exposed.txt",
+    "FilePath": "src/tests/data/secret-exposed.txt",
     "Line": 3
   }
 ]