This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Cleaned up WalletController and LocalBlockchainController classes #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justingaffney
commented
Dec 23, 2017
justingaffney
commented
- Moved account, asset and transaction lists to separate WalletInfo class
- Added FirstClassAssetItem and NEP5AssetItem subclasses of AssetItem
- Replaced static Blockchain.Default references in LocalBlockchainController with references to private field
- Added BaseBlockchainController class to contain logic shared between IBlockchainController implementations
- Moved local node logic to BaseBlockchainController
…on lists to separate WalletInfo class. Added FirstClassAssetItem and NEP5AssetItem subclasses of AssetItem
…oller with references to private field
…chainController implementations
justingaffney
added a commit
that referenced
this pull request
Jan 4, 2018
* Added all tests from TransactionViewModel * Guard replace the IF statement to verify Null parameters in Method * Refactor in TransactionItem where Transaction is not needed. #46 * * Create Base.Tests project to contain the tests in the Base prokect. * Create the TestHelpers project that will contain all the test base classes * TransactionItemTests added. #46 * Cleaned up WalletController and LocalBlockchainController classes (#100) * Moved account, asset and transaction lists to separate WalletInfo class * Added FirstClassAssetItem and NEP5AssetItem subclasses of AssetItem * Replaced static Blockchain.Default references in LocalBlockchainController with references to private field * Added BaseBlockchainController class to contain logic shared between IBlockchainController implementations * Moved local node logic to BaseBlockchainController * Increased UI update timer interval to 1 second * Added NetworkController and BlockchainImporter classes (#101) * Added injectable NetworkController class, moved ControllersRegistrationModule and MessagingRegistrationModule to Neo.Gui.Base project * Moved local node logic to NetworkController class, added NetworkStatus class * Moved status classes to separate namespace, moved blockchain importing logic from LocalBlockchainController to separate BlockchainImporter class * Moved new block event handler to BaseBlockchainController, renamed BlockchainPersistCompletedMessage to BlockAddedMessage * Added Blockchain.RegisterBlockchain call back to LocalBlockchainController The static Blockchain.Default property needs to be set to the blockchain instance * Moved translated strings to separate project (#102) * Removed WalletAccount property from AccountItem to help with creating dummy AccountItem instances during testing (#103) To help with creating dummy AccountItem instances in unit tests * Removed AssetState property from FirstClassAssetItem class (#104) * Removed related account combobox control from ImportCustomContractView #107 Also removed unnecessary "using" directives from ImportCustomContractViewModel * Fixed bug with ILoadable.OnLoad method being called multiple times (#108) * Added ILoadableDialogViewModel interface for loading dialogs with load parameters, prevents ILoadable.OnLoad from being called multiple times * Fixed bug in InternalMessageAggregator where message subscriber instances can subscribe multiple times * Added wallet locker field so wallet can be disposed of correctly * Removed "repair mode" checkbox in OpenWalletView as wallet implementation classes no longer have rebuilding functionality * . * fix a small issue compiling. * ViewModels now call methods in WalletController instead of sending messages. Deleted: SignTransactionAndShowInformationMessage * Removed AddContractMessage, AddContractsMessage, ImportCertificateMessage, ImportPrivateKeyMessage, InvokeContractMessage and replaced with direct method calls to IWalletController. Replaced InvokeContractMessage with IDialogManager.ShowDialog method calls (#111) * merge with DEV and refactor * Merged changes in commit d4162f2 in neo-project/neo-gui (#114) * Moved test-related projects to separate directory, removed "Change Password" dialog, small bug fix (#115) * Moved test-related projects to separate "Tests" directory. Cleaned up and renamed walletcontroller methods. Removed wallet password changing dialog as this functionality is no longer supported * Fixed bug with incorrect asset URL format * Moved IWalletController.GetAccountContract method call from AccountsViewModel to ViewContractViewModel * Small cleanup * Separated interfaces and implementation classes to separate namespaces, general code clean up (#117)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.