Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning when trying to save a key with the same name #398

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

slipo
Copy link
Contributor

@slipo slipo commented Dec 5, 2017

What current issue(s) from Trello/Github does this address?
#396

What problem does this PR solve?
Currently you can accidentally save over preexisting keys by using a key name you've used before.

How did you solve this problem?
Warn the user in a confirmation overlay. They can confirm overwriting the key or cancel and choose a different name.

How did you make sure your solution works?
Save a new key "test". Create another key and try to name it "test"

Are there any special changes in the code that we should be aware of?
no

Is there anything else we should know?
no

  • Unit tests written?

Overlay looks like this in case language/design changes are needed:
key-overlay

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.781% when pulling 8521d76 on slipo:warning-dup-key-name into 77b14d9 on CityOfZion:dev.

@evgenyboxer evgenyboxer merged commit 46422f3 into CityOfZion:dev Dec 6, 2017
@slipo slipo deleted the warning-dup-key-name branch December 6, 2017 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants